Move context-sensitive app.window.* functions to app.window.current().*

chrome/renderer/resources/extensions/app_window_custom_bindings.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Custom bindings for the app_window API.
 
 var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
 var sendRequest = require('sendRequest').sendRequest;
 var appWindowNatives = requireNative('app_window');
 var GetView = appWindowNatives.GetView;
 
 chromeHidden.registerCustomHook('app.window', function(bindingsAPI) {
   var apiFunctions = bindingsAPI.apiFunctions;
   apiFunctions.setCustomCallback('create', function(name, request, viewId) {
     var view = null;
     if (viewId)
       view = GetView(viewId);
     if (request.callback) {
-      request.callback(view);
+      request.callback(view.chrome.app.window.current());
       delete request.callback;
     }
   })
-  apiFunctions.setHandleRequest('moveTo', function(x, y) {
-    window.moveTo(x, y);
-  })
-  apiFunctions.setHandleRequest('resizeTo', function(width, height) {
-    window.resizeTo(width, height);
+  var AppWindow = function() {};
+  for (var fn in chromeHidden.internalAPIs.app.currentWindowInternal) {
+    AppWindow.prototype[fn] =
+        chromeHidden.internalAPIs.app.currentWindowInternal[fn];
+  }
+  AppWindow.prototype.moveTo = window.moveTo.bind(window);

[Mihai Parparita -not on Chrome, 2012/08/24 17:58:09]

Will this do the right thing for manipulating non-current windows? i.e. if I
have in my background page:

chrome.app.window.create({...}, function(appWindow) {
 appWindow.moveTo(0, 0);
});

The moveTo implementation of that AppWindow instance will operate on the
background page's window object, since it was bound at bindings loading time.

It seems like the implementation should instead be:

AppWindow.prototype.moveTo = function(x, y) {
  this.dom.moveTo(x, y);
}

Which reminds me: where is the .dom property implementation?

[jeremya, 2012/08/26 23:49:38]

appWindow in the callback there is the return value of
child.dom.chrome.app.window.current(), so it will be bound in the child window's
context.

The .dom property implementation is ... missing. Fixed :P

+  AppWindow.prototype.resizeTo = window.resizeTo.bind(window);
+  apiFunctions.setHandleRequest('current', function() {
+    return new AppWindow;
   })
 });