Move context-sensitive app.window.* functions to app.window.current().*

chrome/common/extensions/api/app_current_window.idl

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// File-level comment to appease parser. Eventually this will not be necessary.
+
+[internal] namespace app.currentWindow {

[Mihai Parparita -not on Chrome, 2012/08/24 01:05:07]

Other internal APIs (webRequestInternal, fileBrowserHandlerInternal) have an
"Internal" suffix, I would suggest mimicking that here.

[jeremya, 2012/08/24 02:10:08]

Done.

+  interface Functions {
+    // Focus the window.
+    static void focus();
+
+    // Minimize the window.
+    static void minimize();
+
+    // Maximize the window.
+    static void maximize();
+
+    // Restore the window.
+    static void restore();

[benwells, 2012/08/24 01:11:55]

Maybe I am not understanding the change properly, but I find this namespace
confusing, as they don't always run on the current window.

E.g. in the example in the bug description maximize isn't running on the current
window (which is the background page).

[jeremya, 2012/08/24 02:10:08]

This namespace is internal-only. The name 'current' was chosen because when code
is running in the context of the child window, chrome.app.window.current() will
return a wrapper object for the current window. It is technically possible for
the parent window to call child.dom.chrome.app.window.current() (which would
return exactly 'child'), but I don't expect that to be a common pattern.

+  };
+};