Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Issue 10878031: Fix android compile step to respect target config (Closed)

Created:
8 years, 4 months ago by Isaac (away)
Modified:
8 years, 3 months ago
Reviewers:
cmp, Xianzhu, nilesh
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org
Visibility:
Public.

Description

Fix android compile step to respect target config - Add a bash fun to unpack python jsons and get target to make - Changed top level scripts to pass args (factory props) - renamed bb_run_tests -> bb_run_unit_tests - renamed bb_run_content_shell_instrumentation_tests -> bb_run_instrumentation_tests BUG=144470 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153544

Patch Set 1 #

Patch Set 2 : Fix factory props arg passing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -20 lines) Patch
M build/android/buildbot_functions.sh View 1 5 chunks +12 lines, -2 lines 0 comments Download
M build/android/buildbot_fyi_tester.sh View 1 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/buildbot_main.sh View 1 1 chunk +3 lines, -3 lines 0 comments Download
M build/android/buildbot_try_builder.sh View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/buildbot_try_compile.sh View 1 1 chunk +4 lines, -3 lines 0 comments Download
M build/android/buildbot_try_compile_test.sh View 1 1 chunk +5 lines, -5 lines 0 comments Download
M build/android/buildbot_try_tester.sh View 1 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/buildbot_webkit_main.sh View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Isaac (away)
(this patch has to wait for build cl or will break waterfall)
8 years, 4 months ago (2012-08-23 21:47:31 UTC) #1
Xianzhu
lgtm
8 years, 4 months ago (2012-08-23 21:51:43 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 4 months ago (2012-08-24 06:04:39 UTC) #3
Isaac (away)
Needs full lgtm. http://www.quickmeme.com/meme/3qm06h/
8 years, 4 months ago (2012-08-24 07:45:31 UTC) #4
nilesh
LGTM
8 years, 4 months ago (2012-08-24 15:31:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/10878031/1
8 years, 4 months ago (2012-08-25 17:48:35 UTC) #6
commit-bot: I haz the power
Try job failure for 10878031-1 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 4 months ago (2012-08-25 17:55:05 UTC) #7
Isaac (away)
(I need to make some minor changes to top level annotator scripts like buildbot_try_compile.sh before ...
8 years, 4 months ago (2012-08-26 00:26:30 UTC) #8
Isaac (away)
ptal
8 years, 3 months ago (2012-08-26 19:22:03 UTC) #9
nilesh
LGTM
8 years, 3 months ago (2012-08-27 02:59:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/10878031/4003
8 years, 3 months ago (2012-08-27 03:00:31 UTC) #11
commit-bot: I haz the power
Try job failure for 10878031-4003 on mac_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=50723 Step "update" is always ...
8 years, 3 months ago (2012-08-27 03:01:47 UTC) #12
Isaac (away)
8 years, 3 months ago (2012-08-27 21:26:07 UTC) #13
CL committed.

Powered by Google App Engine
This is Rietveld 408576698