net/dns/dns_client.cc - Issue 10878016: [net/dns] Fix leak of DnsSession in DnsClientImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/dns_client.cc

Issue 10878016: [net/dns] Fix leak of DnsSession in DnsClientImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sync Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/dns/dns_client.cc

diff --git a/net/dns/dns_client.cc b/net/dns/dns_client.cc

index 859fc274dfe086af025bc767ce53612e5e9bfe2f..b9c2279a140c2635dc1eb8120ee3fa0f01e86d2e 100644

--- a/net/dns/dns_client.cc

+++ b/net/dns/dns_client.cc

@@ -25,7 +25,7 @@ class DnsClientImpl : public DnsClient {

virtual void SetConfig(const DnsConfig& config) OVERRIDE {

factory_.reset();

- session_.release();

+ session_ = NULL;

if (config.IsValid()) {

session_ = new DnsSession(config,

ClientSocketFactory::GetDefaultFactory(),

« no previous file with comments | « no previous file | no next file » | no next file with comments »