Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 10878007: Index script compilation cache over context (Closed)

Created:
8 years, 4 months ago by rossberg
Modified:
8 years, 3 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Index script compilation cache over context, too, in preparation for global lexical scope. R=ulan@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12397

Patch Set 1 #

Patch Set 2 : Respect language flags. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -31 lines) Patch
M src/api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compilation-cache.h View 3 chunks +14 lines, -5 lines 0 comments Download
M src/compilation-cache.cc View 6 chunks +23 lines, -15 lines 0 comments Download
M src/compiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M src/debug.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/objects.cc View 1 3 chunks +32 lines, -5 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rossberg
8 years, 4 months ago (2012-08-22 12:30:21 UTC) #1
ulan
Could you please check that with this CL we still get compilation cache hits if ...
8 years, 4 months ago (2012-08-22 14:29:49 UTC) #2
rossberg
On 2012/08/22 14:29:49, ulan wrote: > Could you please check that with this CL we ...
8 years, 4 months ago (2012-08-24 12:47:04 UTC) #3
rossberg
On 2012/08/24 12:47:04, rossberg wrote: > Through reflective loads it will probably be possible to ...
8 years, 4 months ago (2012-08-24 12:50:11 UTC) #4
ulan
8 years, 3 months ago (2012-08-28 08:54:07 UTC) #5
LGTM. Can we remove ", too," from the description?

Powered by Google App Engine
This is Rietveld 408576698