lib/compiler/implementation/dart_backend/renamer.dart - Issue 10878004: Properly rename main methods declared in imported libs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/dart_backend/renamer.dart

Issue 10878004: Properly rename main methods declared in imported libs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/compiler/implementation/dart_backend/renamer.dart

diff --git a/lib/compiler/implementation/dart_backend/renamer.dart b/lib/compiler/implementation/dart_backend/renamer.dart

index b1f931552e372e55e069b99c7b4e36de4a4678a6..b00517bc75164b126c3079d7bcb8de476623ea60 100644

--- a/lib/compiler/implementation/dart_backend/renamer.dart

+++ b/lib/compiler/implementation/dart_backend/renamer.dart

@@ -14,6 +14,9 @@ void renamePlaceholders(

final Map<LibraryElement, Map<String, String>> renamed

= new Map<LibraryElement, Map<String, String>>();

final Set<String> usedTopLevelIdentifiers = new Set<String>();

+ // TODO(antonm): we should also populate this set with top-level

+ // names from core library.

+ usedTopLevelIdentifiers.add('main'); // Never rename anything to 'main'.

Generator topLevelGenerator =

true ? conservativeGenerator : new MinifyingGenerator('ABCD').generate;

« no previous file with comments | « no previous file | tests/compiler/dart2js/unparser_test.dart » ('j') | no next file with comments »