Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: net/socket/ssl_client_socket_unittest.cc

Issue 10878003: Refactoring for merging WebSocket test server to net::TestServer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: reflect Ryan's review Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_client_socket_unittest.cc
diff --git a/net/socket/ssl_client_socket_unittest.cc b/net/socket/ssl_client_socket_unittest.cc
index 0c28b2d42360ccf528ff988a4f3bd8cdbd92310d..c251b997e316fa862efce3e0621098a2fa5f9ae5 100644
--- a/net/socket/ssl_client_socket_unittest.cc
+++ b/net/socket/ssl_client_socket_unittest.cc
@@ -110,9 +110,11 @@ TEST_F(SSLClientSocketTest, Connect) {
}
TEST_F(SSLClientSocketTest, ConnectExpired) {
- net::TestServer::HTTPSOptions https_options(
- net::TestServer::HTTPSOptions::CERT_EXPIRED);
- net::TestServer test_server(https_options, FilePath());
+ net::TestServer::SSLOptions ssl_options(
+ net::TestServer::SSLOptions::CERT_EXPIRED);
+ net::TestServer test_server(net::TestServer::TYPE_HTTPS,
+ ssl_options,
+ FilePath());
ASSERT_TRUE(test_server.Start());
cert_verifier_->set_default_result(net::ERR_CERT_DATE_INVALID);
@@ -155,9 +157,11 @@ TEST_F(SSLClientSocketTest, ConnectExpired) {
}
TEST_F(SSLClientSocketTest, ConnectMismatched) {
- net::TestServer::HTTPSOptions https_options(
- net::TestServer::HTTPSOptions::CERT_MISMATCHED_NAME);
- net::TestServer test_server(https_options, FilePath());
+ net::TestServer::SSLOptions ssl_options(
+ net::TestServer::SSLOptions::CERT_MISMATCHED_NAME);
+ net::TestServer test_server(net::TestServer::TYPE_HTTPS,
+ ssl_options,
+ FilePath());
ASSERT_TRUE(test_server.Start());
cert_verifier_->set_default_result(net::ERR_CERT_COMMON_NAME_INVALID);
@@ -202,9 +206,11 @@ TEST_F(SSLClientSocketTest, ConnectMismatched) {
// Attempt to connect to a page which requests a client certificate. It should
// return an error code on connect.
TEST_F(SSLClientSocketTest, ConnectClientAuthCertRequested) {
- net::TestServer::HTTPSOptions https_options;
- https_options.request_client_certificate = true;
- net::TestServer test_server(https_options, FilePath());
+ net::TestServer::SSLOptions ssl_options;
+ ssl_options.request_client_certificate = true;
+ net::TestServer test_server(net::TestServer::TYPE_HTTPS,
+ ssl_options,
+ FilePath());
ASSERT_TRUE(test_server.Start());
net::AddressList addr;
@@ -262,9 +268,11 @@ TEST_F(SSLClientSocketTest, ConnectClientAuthCertRequested) {
//
// TODO(davidben): Also test providing an actual certificate.
TEST_F(SSLClientSocketTest, ConnectClientAuthSendNullCert) {
- net::TestServer::HTTPSOptions https_options;
- https_options.request_client_certificate = true;
- net::TestServer test_server(https_options, FilePath());
+ net::TestServer::SSLOptions ssl_options;
+ ssl_options.request_client_certificate = true;
+ net::TestServer test_server(net::TestServer::TYPE_HTTPS,
+ ssl_options,
+ FilePath());
ASSERT_TRUE(test_server.Start());
net::AddressList addr;
@@ -667,11 +675,13 @@ TEST_F(SSLClientSocketTest, CipherSuiteDisables) {
0x0005, // TLS_RSA_WITH_RC4_128_SHA
};
- net::TestServer::HTTPSOptions https_options;
+ net::TestServer::SSLOptions ssl_options;
// Enable only RC4 on the test server.
- https_options.bulk_ciphers =
- net::TestServer::HTTPSOptions::BULK_CIPHER_RC4;
- net::TestServer test_server(https_options, FilePath());
+ ssl_options.bulk_ciphers =
+ net::TestServer::SSLOptions::BULK_CIPHER_RC4;
+ net::TestServer test_server(net::TestServer::TYPE_HTTPS,
+ ssl_options,
+ FilePath());
ASSERT_TRUE(test_server.Start());
net::AddressList addr;
@@ -869,9 +879,10 @@ TEST_F(SSLClientSocketTest, VerifyReturnChainProperlyOrdered) {
net::ScopedTestRoot scoped_root(root_cert);
// Set up a test server with CERT_CHAIN_WRONG_ROOT.
- net::TestServer::HTTPSOptions https_options(
- net::TestServer::HTTPSOptions::CERT_CHAIN_WRONG_ROOT);
- net::TestServer test_server(https_options,
+ net::TestServer::SSLOptions ssl_options(
+ net::TestServer::SSLOptions::CERT_CHAIN_WRONG_ROOT);
+ net::TestServer test_server(net::TestServer::TYPE_HTTPS,
+ ssl_options,
FilePath(FILE_PATH_LITERAL("net/data/ssl")));
ASSERT_TRUE(test_server.Start());

Powered by Google App Engine
This is Rietveld 408576698