Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1255)

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 10878003: Refactoring for merging WebSocket test server to net::TestServer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: reflect Ryan's review Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_browsertest.cc
diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc
index a6ec4b3f1d4be88fe6d0f0274a1fa272ec18617a..00dce07cdbf37db346c536c71502382ec496324d 100644
--- a/chrome/browser/prerender/prerender_browsertest.cc
+++ b/chrome/browser/prerender/prerender_browsertest.cc
@@ -1860,10 +1860,11 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderXhrDelete) {
// Checks that a top-level page which would trigger an SSL error is canceled.
IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderSSLErrorTopLevel) {
- net::TestServer::HTTPSOptions https_options;
- https_options.server_certificate =
- net::TestServer::HTTPSOptions::CERT_MISMATCHED_NAME;
- net::TestServer https_server(https_options,
+ net::TestServer::SSLOptions ssl_options;
+ ssl_options.server_certificate =
+ net::TestServer::SSLOptions::CERT_MISMATCHED_NAME;
+ net::TestServer https_server(net::TestServer::TYPE_HTTPS,
+ ssl_options,
FilePath(FILE_PATH_LITERAL("chrome/test/data")));
ASSERT_TRUE(https_server.Start());
GURL https_url = https_server.GetURL("files/prerender/prerender_page.html");
@@ -1876,10 +1877,11 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderSSLErrorTopLevel) {
// the page. Non-main-frame requests are simply cancelled if they run into
// an SSL problem.
IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderSSLErrorSubresource) {
- net::TestServer::HTTPSOptions https_options;
- https_options.server_certificate =
- net::TestServer::HTTPSOptions::CERT_MISMATCHED_NAME;
- net::TestServer https_server(https_options,
+ net::TestServer::SSLOptions ssl_options;
+ ssl_options.server_certificate =
+ net::TestServer::SSLOptions::CERT_MISMATCHED_NAME;
+ net::TestServer https_server(net::TestServer::TYPE_HTTPS,
+ ssl_options,
FilePath(FILE_PATH_LITERAL("chrome/test/data")));
ASSERT_TRUE(https_server.Start());
GURL https_url = https_server.GetURL("files/prerender/image.jpeg");
@@ -1899,10 +1901,11 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderSSLErrorSubresource) {
// the page. Non-main-frame requests are simply cancelled if they run into
// an SSL problem.
IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderSSLErrorIframe) {
- net::TestServer::HTTPSOptions https_options;
- https_options.server_certificate =
- net::TestServer::HTTPSOptions::CERT_MISMATCHED_NAME;
- net::TestServer https_server(https_options,
+ net::TestServer::SSLOptions ssl_options;
+ ssl_options.server_certificate =
+ net::TestServer::SSLOptions::CERT_MISMATCHED_NAME;
+ net::TestServer https_server(net::TestServer::TYPE_HTTPS,
+ ssl_options,
FilePath(FILE_PATH_LITERAL("chrome/test/data")));
ASSERT_TRUE(https_server.Start());
GURL https_url = https_server.GetURL(
@@ -1949,9 +1952,10 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
// Checks that a top-level page which would normally request an SSL client
// certificate will never be seen since it's an https top-level resource.
IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderSSLClientCertTopLevel) {
- net::TestServer::HTTPSOptions https_options;
- https_options.request_client_certificate = true;
- net::TestServer https_server(https_options,
+ net::TestServer::SSLOptions ssl_options;
+ ssl_options.request_client_certificate = true;
+ net::TestServer https_server(net::TestServer::TYPE_HTTPS,
+ ssl_options,
FilePath(FILE_PATH_LITERAL("chrome/test/data")));
ASSERT_TRUE(https_server.Start());
GURL https_url = https_server.GetURL("files/prerender/prerender_page.html");
@@ -1962,9 +1966,10 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderSSLClientCertTopLevel) {
// subresource will cancel the prerendered page.
IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
PrerenderSSLClientCertSubresource) {
- net::TestServer::HTTPSOptions https_options;
- https_options.request_client_certificate = true;
- net::TestServer https_server(https_options,
+ net::TestServer::SSLOptions ssl_options;
+ ssl_options.request_client_certificate = true;
+ net::TestServer https_server(net::TestServer::TYPE_HTTPS,
+ ssl_options,
FilePath(FILE_PATH_LITERAL("chrome/test/data")));
ASSERT_TRUE(https_server.Start());
GURL https_url = https_server.GetURL("files/prerender/image.jpeg");
@@ -1984,9 +1989,10 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
// Checks that an SSL Client Certificate request that originates from an
// iframe will cancel the prerendered page.
IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderSSLClientCertIframe) {
- net::TestServer::HTTPSOptions https_options;
- https_options.request_client_certificate = true;
- net::TestServer https_server(https_options,
+ net::TestServer::SSLOptions ssl_options;
+ ssl_options.request_client_certificate = true;
+ net::TestServer https_server(net::TestServer::TYPE_HTTPS,
+ ssl_options,
FilePath(FILE_PATH_LITERAL("chrome/test/data")));
ASSERT_TRUE(https_server.Start());
GURL https_url = https_server.GetURL(

Powered by Google App Engine
This is Rietveld 408576698