Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10877014: Moved the video encoders/decoders to the codec directory. (Closed)

Created:
8 years, 4 months ago by kxing
Modified:
8 years, 4 months ago
Reviewers:
Sergey Ulanov, Wez, garykac
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Moved the video encoders/decoders to the codec directory. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152912

Patch Set 1 #

Total comments: 12

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -2198 lines) Patch
D remoting/base/base_mock_objects.h View 1 chunk +0 lines, -31 lines 0 comments Download
D remoting/base/base_mock_objects.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D remoting/base/codec_test.h View 1 chunk +0 lines, -40 lines 0 comments Download
D remoting/base/codec_test.cc View 1 chunk +0 lines, -497 lines 0 comments Download
D remoting/base/decoder.h View 1 chunk +0 lines, -75 lines 0 comments Download
D remoting/base/decoder_row_based.h View 1 chunk +0 lines, -84 lines 0 comments Download
D remoting/base/decoder_row_based.cc View 1 chunk +0 lines, -225 lines 0 comments Download
D remoting/base/decoder_vp8.h View 1 chunk +0 lines, -60 lines 0 comments Download
D remoting/base/decoder_vp8.cc View 1 chunk +0 lines, -211 lines 0 comments Download
D remoting/base/decoder_vp8_unittest.cc View 1 chunk +0 lines, -74 lines 0 comments Download
D remoting/base/encode_decode_unittest.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D remoting/base/encoder.h View 1 chunk +0 lines, -48 lines 0 comments Download
D remoting/base/encoder_row_based.h View 1 chunk +0 lines, -71 lines 0 comments Download
D remoting/base/encoder_row_based.cc View 1 chunk +0 lines, -177 lines 0 comments Download
D remoting/base/encoder_row_based_unittest.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D remoting/base/encoder_vp8.h View 1 chunk +0 lines, -64 lines 0 comments Download
D remoting/base/encoder_vp8.cc View 1 chunk +0 lines, -307 lines 0 comments Download
D remoting/base/encoder_vp8_unittest.cc View 1 chunk +0 lines, -96 lines 0 comments Download
M remoting/client/rectangle_update_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/rectangle_update_decoder.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + remoting/codec/codec_test.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/codec/codec_test.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
A + remoting/codec/video_decoder.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/codec/video_decoder_row_based.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + remoting/codec/video_decoder_row_based.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/codec/video_decoder_vp8.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + remoting/codec/video_decoder_vp8.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/codec/video_decoder_vp8_unittest.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
A + remoting/codec/video_encode_decode_unittest.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
A + remoting/codec/video_encoder.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/codec/video_encoder_row_based.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + remoting/codec/video_encoder_row_based.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/codec/video_encoder_row_based_unittest.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
A + remoting/codec/video_encoder_vp8.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + remoting/codec/video_encoder_vp8.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/codec/video_encoder_vp8_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M remoting/host/chromoting_host.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/chromoting_host.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/screen_recorder.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/screen_recorder_unittest.cc View 1 2 chunks +20 lines, -1 line 0 comments Download
M remoting/protocol/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/connection_to_client_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/remoting.gyp View 1 3 chunks +16 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kxing
Could someone PTAL?
8 years, 4 months ago (2012-08-22 14:28:17 UTC) #1
Sergey Ulanov
LGTM, but please see my nits https://chromiumcodereview.appspot.com/10877014/diff/1/remoting/codec/mock_video_encoder.h File remoting/codec/mock_video_encoder.h (right): https://chromiumcodereview.appspot.com/10877014/diff/1/remoting/codec/mock_video_encoder.h#newcode14 remoting/codec/mock_video_encoder.h:14: class MockEncoder : ...
8 years, 4 months ago (2012-08-22 16:10:28 UTC) #2
kxing
I'll commit this soon, unless someone objects. http://codereview.chromium.org/10877014/diff/1/remoting/codec/mock_video_encoder.h File remoting/codec/mock_video_encoder.h (right): http://codereview.chromium.org/10877014/diff/1/remoting/codec/mock_video_encoder.h#newcode14 remoting/codec/mock_video_encoder.h:14: class MockEncoder ...
8 years, 4 months ago (2012-08-22 17:08:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kxing@chromium.org/10877014/2002
8 years, 4 months ago (2012-08-22 17:46:54 UTC) #4
commit-bot: I haz the power
Try job failure for 10877014-2002 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-22 19:49:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kxing@chromium.org/10877014/2002
8 years, 4 months ago (2012-08-22 23:16:25 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-23 01:36:11 UTC) #7 
Change committed as 152912

Powered by Google App Engine
This is Rietveld 408576698