Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2025)

Unified Diff: runtime/vm/object.cc

Issue 10876100: Convert double interface into abstract class (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc (revision 11396)
+++ runtime/vm/object.cc (working copy)
@@ -778,10 +778,12 @@
type = Type::NewNonParameterizedType(cls);
object_store->set_int_interface(type);
- cls = CreateAndRegisterInterface("double", script, core_lib);
+ name = Symbols::New("double");
+ cls = Class::New<Instance>(name, script, Scanner::kDummyTokenIndex);
+ RegisterClass(cls, name, core_lib);
siva 2012/08/29 23:49:36 TODO to remove this once patching of double class
pending_classes.Add(cls, Heap::kOld);
type = Type::NewNonParameterizedType(cls);
- object_store->set_double_interface(type);
+ object_store->set_double_type(type);
cls = CreateAndRegisterInterface("String", script, core_lib);
pending_classes.Add(cls, Heap::kOld);
@@ -807,10 +809,6 @@
type = Type::NewNonParameterizedType(cls);
object_store->set_smi_type(type);
- cls = object_store->double_class();
- type = Type::NewNonParameterizedType(cls);
- object_store->set_double_type(type);
-
cls = object_store->mint_class();
type = Type::NewNonParameterizedType(cls);
object_store->set_mint_type(type);
@@ -2568,9 +2566,9 @@
}
-bool AbstractType::IsDoubleInterface() const {
+bool AbstractType::IsDoubleType() const {
return HasResolvedTypeClass() &&
- (type_class() == Type::Handle(Type::DoubleInterface()).type_class());
+ (type_class() == Type::Handle(Type::Double()).type_class());
}
@@ -2709,8 +2707,8 @@
}
-RawType* Type::DoubleInterface() {
- return Isolate::Current()->object_store()->double_interface();
+RawType* Type::Double() {
+ return Isolate::Current()->object_store()->double_type();
}

Powered by Google App Engine
This is Rietveld 408576698