chrome/browser/media_gallery/media_device_notifications_window_win_unittest.cc - Issue 10876093: Improve the device type constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_gallery/media_device_notifications_window_win_unittest.cc

Issue 10876093: Improve the device type constants. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_gallery/media_device_notifications_window_win.cc ('k') | chrome/browser/media_gallery/media_file_system_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_gallery/media_device_notifications_window_win_unittest.cc

diff --git a/chrome/browser/media_gallery/media_device_notifications_window_win_unittest.cc b/chrome/browser/media_gallery/media_device_notifications_window_win_unittest.cc

index 77c31a014ad8b736d8fff468ca44ffd814aa2bb0..4556a34cabb67305dcfd142661a662fdb2e160e6 100644

--- a/chrome/browser/media_gallery/media_device_notifications_window_win_unittest.cc

+++ b/chrome/browser/media_gallery/media_device_notifications_window_win_unittest.cc

@@ -103,7 +103,8 @@ void MediaDeviceNotificationsWindowWinTest::DoDevicesAttachedTest(

drive[0] = 'A' + *it;

FilePath::StringType name = L"V" + drive;

std::string device_id = MediaStorageUtil::MakeDeviceId(

- MediaStorageUtil::USB_MASS_STORAGE_WITH_DCIM, base::IntToString(*it));

+ MediaStorageUtil::REMOVABLE_MASS_STORAGE_WITH_DCIM,

+ base::IntToString(*it));

EXPECT_CALL(observer_, OnRemovableStorageAttached(device_id, name, drive))

.Times(0);

}

@@ -127,7 +128,8 @@ void MediaDeviceNotificationsWindowWinTest::DoDevicesDetachedTest(

++it) {

volume_broadcast.dbcv_unitmask |= 0x1 << *it;

std::string device_id = MediaStorageUtil::MakeDeviceId(

- MediaStorageUtil::USB_MASS_STORAGE_WITH_DCIM, base::IntToString(*it));

+ MediaStorageUtil::REMOVABLE_MASS_STORAGE_WITH_DCIM,

+ base::IntToString(*it));

EXPECT_CALL(observer_, OnRemovableStorageDetached(device_id)).Times(0);

}