chrome/browser/media_gallery/media_device_notifications_window_win.cc - Issue 10876093: Improve the device type constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_gallery/media_device_notifications_window_win.cc

Issue 10876093: Improve the device type constants. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_gallery/media_device_notifications_linux_unittest.cc ('k') | chrome/browser/media_gallery/media_device_notifications_window_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_gallery/media_device_notifications_window_win.cc

diff --git a/chrome/browser/media_gallery/media_device_notifications_window_win.cc b/chrome/browser/media_gallery/media_device_notifications_window_win.cc

index 10907eb487d4e18ffc9397ec4c0cad7890e9efd2..90e2013bccf630732d2e36e021f24ab3d41c2757 100644

--- a/chrome/browser/media_gallery/media_device_notifications_window_win.cc

+++ b/chrome/browser/media_gallery/media_device_notifications_window_win.cc

@@ -104,7 +104,7 @@ LRESULT MediaDeviceNotificationsWindowWin::OnDeviceChange(UINT event_type,

// TODO(kmadhusu) We need to look up a real device id as well as

// having a fall back for volume name.

std::string device_id = MediaStorageUtil::MakeDeviceId(

- MediaStorageUtil::USB_MASS_STORAGE_WITH_DCIM,

+ MediaStorageUtil::REMOVABLE_MASS_STORAGE_WITH_DCIM,

base::IntToString(i));

BrowserThread::PostTask(

BrowserThread::FILE, FROM_HERE,

@@ -121,7 +121,7 @@ LRESULT MediaDeviceNotificationsWindowWin::OnDeviceChange(UINT event_type,

for (int i = 0; unitmask; ++i, unitmask >>= 1) {

if (unitmask & 0x01) {

std::string device_id = MediaStorageUtil::MakeDeviceId(

- MediaStorageUtil::USB_MASS_STORAGE_WITH_DCIM,

+ MediaStorageUtil::REMOVABLE_MASS_STORAGE_WITH_DCIM,

base::IntToString(i));

SystemMonitor::Get()->ProcessRemovableStorageDetached(device_id);

}