Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: chrome/browser/media_gallery/media_storage_util.h

Issue 10876093: Improve the device type constants. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media_gallery/media_storage_util.h
diff --git a/chrome/browser/media_gallery/media_storage_util.h b/chrome/browser/media_gallery/media_storage_util.h
index 4d3d9856453e27524035843591adbb3e0bd0aacc..152878e31fc687635f0abfc733ae8b8946551db6 100644
--- a/chrome/browser/media_gallery/media_storage_util.h
+++ b/chrome/browser/media_gallery/media_storage_util.h
@@ -19,14 +19,14 @@ namespace chrome {
class MediaStorageUtil {
public:
enum Type {
- // A USB mass storage device with a DCIM directory.
- USB_MASS_STORAGE_WITH_DCIM,
- // A USB mass storage device without a DCIM directory.
- USB_MASS_STORAGE_NO_DCIM,
- // Mass storage not connected through USB - a proxy for fixed/removable.
- OTHER_MASS_STORAGE,
+ // A removable mass storage device with a DCIM directory.
+ REMOVALBE_MASS_STORAGE_WITH_DCIM,
Lei Zhang 2012/08/27 23:06:59 typo here and below and everywhere else.
+ // A removable mass storage device without a DCIM directory.
+ REMOVALBE_MASS_STORAGE_NO_DCIM,
+ // A fixed mass storage device.
+ FIXED_MASS_STORAGE,
// A MTP or PTP device.
- USB_MTP,
+ MTP_OR_PTP,
};
typedef base::Callback<void(bool)> BoolCallback;
@@ -46,11 +46,11 @@ class MediaStorageUtil {
Type* type, std::string* unique_id);
// Looks inside |device_id| to determine if it is a media device
- // (type is USB_MASS_STORAGE_WITH_DCIM or USB_MTP).
+ // (type is REMOVALBE_MASS_STORAGE_WITH_DCIM or MTP_OR_PTP).
static bool IsMediaDevice(const std::string& device_id);
// Looks inside |device_id| to determine if it is a media device
- // (type isn't OTHER_MASS_STORAGE).
+ // (type isn't FIXED_MASS_STORAGE).
static bool IsRemovableDevice(const std::string& device_id);
// Determines if the device is attached to the computer.
« no previous file with comments | « chrome/browser/media_gallery/media_file_system_registry.cc ('k') | chrome/browser/media_gallery/media_storage_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698