[4] Changing content_settings_api to use PluginFinder's async interface

chrome/browser/extensions/api/content_settings/content_settings_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_CONTENT_SETTINGS_CONTENT_SETTINGS_API_H__
 #define CHROME_BROWSER_EXTENSIONS_API_CONTENT_SETTINGS_CONTENT_SETTINGS_API_H__
 
 #include "chrome/browser/extensions/extension_function.h"
+#include "chrome/browser/plugin_finder.h"
 
 namespace webkit {
 namespace npapi {
 class PluginGroup;
 }
 }
 
 namespace extensions {
 
 class ClearContentSettingsFunction : public SyncExtensionFunction {
@@ skipping 36 matching lines @@
  protected:
   virtual ~GetResourceIdentifiersFunction() {}
 
   // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 
  private:
   FRIEND_TEST_ALL_PREFIXES(ExtensionApiTest,
                            ContentSettingsGetResourceIdentifiers);
 
-  void OnGotPluginGroups(const std::vector<webkit::npapi::PluginGroup>& groups);
+  void OnGotPlugins(PluginFinder* finder,

[Mattias Nissler (ping if slow), 2012/08/27 15:42:09]

This could also use some documentation on when and from where it gets called.

[ibraaaa, 2012/08/27 17:34:05]

Done.

+                    const std::vector<webkit::WebPluginInfo>& plugins);
+
+  // Callback method called by RunImpl. It takes in the asynchronously created
+  // PluginFinder instance. It delegates the logic (async) to OnGotPlugins.
+  void GetPluginFinderForRunImpl(PluginFinder* finder);
 
   // Used to override the global plugin list in tests.
-  static void SetPluginGroupsForTesting(
-      const std::vector<webkit::npapi::PluginGroup>* plugin_groups);
+  static void SetPluginsForTesting(
+      const std::vector<webkit::WebPluginInfo>* plugins);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_CONTENT_SETTINGS_CONTENT_SETTINGS_API_H__