Support for newer versions of Solaris and FreeBSD

Support for newer versions of Solaris and FreeBSD.

R=thakis@chromium.org
BUG=v8:2010
gyp r1482

[Nico, 2012-08-27 15:52:25]

https://chromiumcodereview.appspot.com/10876082/diff/3001/pylib/gyp/common.py
File pylib/gyp/common.py (right):

https://chromiumcodereview.appspot.com/10876082/diff/3001/pylib/gyp/common.py...
pylib/gyp/common.py:367: return params.['flavor']
This doesn't look like it'd ever execute successfully. How did you test this
change?

[Yang, 2012-08-28 08:00:35]

On 2012/08/27 15:52:25, Nico wrote:
> https://chromiumcodereview.appspot.com/10876082/diff/3001/pylib/gyp/common.py
> File pylib/gyp/common.py (right):
> 
>
https://chromiumcodereview.appspot.com/10876082/diff/3001/pylib/gyp/common.py...
> pylib/gyp/common.py:367: return params.['flavor']
> This doesn't look like it'd ever execute successfully. How did you test this
> change?

Looks like I should have rerun the test suite for those last minute changes.

There is no test that specifically tests this function. I could think of a test
where sys.platform is set manually and the output of the function is tested.
However, I don't know where I would have to put such a test in the test suite.

[Nico, 2012-08-28 14:42:14]

lgtm except for nits

I meant more "how did you test this manually"

https://chromiumcodereview.appspot.com/10876082/diff/6001/pylib/gyp/common.py
File pylib/gyp/common.py (right):

https://chromiumcodereview.appspot.com/10876082/diff/6001/pylib/gyp/common.py...
pylib/gyp/common.py:363: 'darwin': 'mac'
leave the trailing , here

https://chromiumcodereview.appspot.com/10876082/diff/6001/pylib/gyp/common.py...
pylib/gyp/common.py:368: elif sys.platform in flavors:
s/elif/if/

https://chromiumcodereview.appspot.com/10876082/diff/6001/pylib/gyp/common.py...
pylib/gyp/common.py:375: return 'linux';
no semicolon

[Yang, 2012-08-28 15:16:09]

On 2012/08/28 14:42:14, Nico wrote:
> lgtm except for nits
> 
> I meant more "how did you test this manually"
> 
> https://chromiumcodereview.appspot.com/10876082/diff/6001/pylib/gyp/common.py
> File pylib/gyp/common.py (right):
> 
>
https://chromiumcodereview.appspot.com/10876082/diff/6001/pylib/gyp/common.py...
> pylib/gyp/common.py:363: 'darwin': 'mac'
> leave the trailing , here
> 
>
https://chromiumcodereview.appspot.com/10876082/diff/6001/pylib/gyp/common.py...
> pylib/gyp/common.py:368: elif sys.platform in flavors:
> s/elif/if/
> 
>
https://chromiumcodereview.appspot.com/10876082/diff/6001/pylib/gyp/common.py...
> pylib/gyp/common.py:375: return 'linux';
> no semicolon

Addressed your comments. I actually found the place where I could add test cases
for gyp.common, so I did. Can be run with

python gyptest.py test/small/gyptest-small.py

I'm not a committer for GYP, so it would be great if you could land this patch
for me. Thanks!

[Nico, 2012-08-28 16:10:11]

LGTM

Thanks, I'll land tomorrow. (Or you can run `gcl try mychangename`, and if all
trybots come back green I don't need to run tests myself and can land it today.)

[Nico, 2012-08-28 16:30:54]

Landed in gyp r1482