Get fix_test_cases.py to run on Windows

Get fix_test_cases.py to run on Windows


BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153558

[M-A Ruel, 2012-08-27 14:21:51]

http://codereview.chromium.org/10876080/diff/1/tools/isolate/fix_test_cases.py
File tools/isolate/fix_test_cases.py (right):

http://codereview.chromium.org/10876080/diff/1/tools/isolate/fix_test_cases.p...
tools/isolate/fix_test_cases.py:174: if sys.platform == 'win32' or sys.platform
== 'cygwin':
if sys.platform in ('cygwin', 'win32'):

http://codereview.chromium.org/10876080/diff/1/tools/isolate/fix_test_cases.p...
tools/isolate/fix_test_cases.py:175: executable = '../../build/Release/%s' %
basename
Actually, that's kind of crappy, I'd rather remove the hard-coded path
completely as I tried to avoid these in general. I've been lousy on this script.

[M-A Ruel, 2012-08-27 15:31:09]

http://codereview.chromium.org/10876080/diff/1/tools/isolate/fix_test_cases.py
File tools/isolate/fix_test_cases.py (right):

http://codereview.chromium.org/10876080/diff/1/tools/isolate/fix_test_cases.p...
tools/isolate/fix_test_cases.py:179: if sys.platform == 'win32':
cygwin too. But I don't think tracing works.

[csharp, 2012-08-27 15:52:41]

http://codereview.chromium.org/10876080/diff/1/tools/isolate/fix_test_cases.py
File tools/isolate/fix_test_cases.py (right):

http://codereview.chromium.org/10876080/diff/1/tools/isolate/fix_test_cases.p...
tools/isolate/fix_test_cases.py:174: if sys.platform == 'win32' or sys.platform
== 'cygwin':
On 2012/08/27 14:21:51, Marc-Antoine Ruel wrote:
> if sys.platform in ('cygwin', 'win32'):

Done.

http://codereview.chromium.org/10876080/diff/1/tools/isolate/fix_test_cases.p...
tools/isolate/fix_test_cases.py:175: executable = '../../build/Release/%s' %
basename
On 2012/08/27 14:21:51, Marc-Antoine Ruel wrote:
> Actually, that's kind of crappy, I'd rather remove the hard-coded path
> completely as I tried to avoid these in general. I've been lousy on this
script.

Done.

http://codereview.chromium.org/10876080/diff/1/tools/isolate/fix_test_cases.p...
tools/isolate/fix_test_cases.py:179: if sys.platform == 'win32':
On 2012/08/27 15:31:09, Marc-Antoine Ruel wrote:
> cygwin too. But I don't think tracing works.

Done.

[M-A Ruel, 2012-08-27 19:24:34]

lgtm

http://codereview.chromium.org/10876080/diff/2002/tools/isolate/fix_test_case...
File tools/isolate/fix_test_cases.py (right):

http://codereview.chromium.org/10876080/diff/2002/tools/isolate/fix_test_case...
tools/isolate/fix_test_cases.py:168: parser.add_option('-d', '--dir',
default='../../out/Release',
(Note that I use ninja on Windows)

[commit-bot: I haz the power, 2012-08-27 19:40:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csharp@chromium.org/10876080/2002

[commit-bot: I haz the power, 2012-08-27 22:16:07]

Change committed as 153558