Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: runtime/vm/intermediate_language.h

Issue 10876079: Clean up LoadInstanceField and StoreInstanceField. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language.h
===================================================================
--- runtime/vm/intermediate_language.h (revision 11378)
+++ runtime/vm/intermediate_language.h (working copy)
@@ -1040,11 +1040,7 @@
class LoadInstanceFieldComp : public TemplateComputation<1> {
public:
- // Set 'original' to NULL if LoadInstanceFieldComp cannot deoptimize.
- LoadInstanceFieldComp(const Field& field,
- Value* instance,
- InstanceCallComp* original)
- : field_(field), original_(original) {
+ LoadInstanceFieldComp(const Field& field, Value* instance) : field_(field) {
ASSERT(instance != NULL);
inputs_[0] = instance;
}
@@ -1053,16 +1049,14 @@
const Field& field() const { return field_; }
Value* instance() const { return inputs_[0]; }
- const InstanceCallComp* original() const { return original_; }
virtual void PrintOperandsTo(BufferFormatter* f) const;
- virtual bool CanDeoptimize() const { return original_ != NULL; }
+ virtual bool CanDeoptimize() const { return false; }
virtual intptr_t ResultCid() const { return kDynamicCid; }
private:
const Field& field_;
- const InstanceCallComp* original_; // For optimizations.
DISALLOW_COPY_AND_ASSIGN(LoadInstanceFieldComp);
};
@@ -1070,12 +1064,10 @@
class StoreInstanceFieldComp : public TemplateComputation<2> {
public:
- // Set 'original' to NULL if StoreInstanceFieldComp cannot deoptimize.
StoreInstanceFieldComp(const Field& field,
Value* instance,
- Value* value,
- InstanceCallComp* original) // Maybe NULL.
- : field_(field), original_(original) {
+ Value* value)
+ : field_(field) {
ASSERT(instance != NULL);
ASSERT(value != NULL);
inputs_[0] = instance;
@@ -1089,16 +1081,13 @@
Value* instance() const { return inputs_[0]; }
Value* value() const { return inputs_[1]; }
- const InstanceCallComp* original() const { return original_; }
-
virtual void PrintOperandsTo(BufferFormatter* f) const;
- virtual bool CanDeoptimize() const { return original_ != NULL; }
+ virtual bool CanDeoptimize() const { return false; }
virtual intptr_t ResultCid() const { return kDynamicCid; }
private:
const Field& field_;
- const InstanceCallComp* original_; // For optimizations.
DISALLOW_COPY_AND_ASSIGN(StoreInstanceFieldComp);
};
@@ -2083,6 +2072,8 @@
intptr_t deopt_id() const { return original_->deopt_id(); }
intptr_t try_index() const { return original_->try_index(); }
+ virtual Definition* TryReplace(BindInstr* instr) const;
+
virtual void PrintOperandsTo(BufferFormatter* f) const;
private:

Powered by Google App Engine
This is Rietveld 408576698