tools/testing/dart/test_suite.dart - Issue 10876078: Better splitting of flag string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_suite.dart

Issue 10876078: Better splitting of flag string. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/testing/dart/test_suite.dart

diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart

index 0fed8954da4d5ed6addb1aab934cdc41e6ae1286..bd8d4bdc156efad1097379c35a3557b9bdcc0a50 100644

--- a/tools/testing/dart/test_suite.dart

+++ b/tools/testing/dart/test_suite.dart

@@ -450,7 +450,10 @@ class StandardTestSuite implements TestSuite {

var compilerArguments = new List.from(args);

var additionalFlags =

configuration['additional-compiler-flags'].split(' ');

- compilerArguments.addAll(additionalFlags);

+ for (final flag in additionalFlags) {

+ if (flag.isEmpty()) continue;

+ compilerArguments.add(flag);

+ }

compilerArguments.add('--output-type=dart');

String tempDir = createOutputDirectory(info.filePath, '');

compilerArguments.add('--out=$tempDir/out.dart');

« no previous file with comments | « no previous file | no next file » | no next file with comments »