Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/intermediate_language.cc

Issue 10876072: Use type propagation to eliminate store barriers. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.cc
===================================================================
--- runtime/vm/intermediate_language.cc (revision 11354)
+++ runtime/vm/intermediate_language.cc (working copy)
@@ -292,6 +292,17 @@
}
+bool Value::NeedsStoreBuffer() const {
+ const intptr_t cid = ResultCid();
+ if ((cid == kSmiCid) || (cid == kBoolCid) || (cid == kNullCid)) {
+ return false;
+ }
+ if (BindsToConstant()) return false;
Ivan Posva 2012/08/25 00:20:51 return !BindsToConstant();
srdjan 2012/08/25 00:25:52 Done.
+ return true;
+}
+
+
Ivan Posva 2012/08/25 00:20:51 Extra line.
srdjan 2012/08/25 00:25:52 Done.
+
RawAbstractType* PhiInstr::CompileType() const {
ASSERT(!HasPropagatedType());
// Since type propagation has not yet occured, we are reaching this phi via a
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698