Issue 10876072: Use type propagation to eliminate store barriers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10876072: Use type propagation to eliminate store barriers. (Closed)

Created:
8 years, 4 months ago by srdjan

Modified:
8 years, 4 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Use type propagation to eliminate store barriers. Committed: https://code.google.com/p/dart/source/detail?r=11357

Patch Set 3 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -34 lines)			Patch
M	runtime/vm/intermediate_language.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2	2 chunks	+16 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View		4 chunks	+16 lines, -16 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View		4 chunks	+16 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://chromiumcodereview.appspot.com/10876072/diff/1/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://chromiumcodereview.appspot.com/10876072/diff/1/runtime/vm/intermediate_language.cc#newcode300 runtime/vm/intermediate_language.cc:300: if (BindsToConstant()) return false; return !BindsToConstant(); https://chromiumcodereview.appspot.com/10876072/diff/1/runtime/vm/intermediate_language.cc#newcode304 ...

8 years, 4 months ago (2012-08-25 00:20:51 UTC) #2

srdjan

8 years, 4 months ago (2012-08-25 00:25:52 UTC) #3

Also added a check for StoreVMFieldComp

https://chromiumcodereview.appspot.com/10876072/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.cc (right):

https://chromiumcodereview.appspot.com/10876072/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.cc:300: if (BindsToConstant()) return false;
On 2012/08/25 00:20:51, Ivan Posva wrote:
> return !BindsToConstant();

Done.

https://chromiumcodereview.appspot.com/10876072/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.cc:304: 
On 2012/08/25 00:20:51, Ivan Posva wrote:
> Extra line.

Done.

Expand Messages | Collapse Messages

Issue 10876072: Use type propagation to eliminate store barriers. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages