src/contexts.cc - Issue 10876067: Introduce global contexts to represent lexical global scope(s).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/contexts.cc

Issue 10876067: Introduce global contexts to represent lexical global scope(s). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed Sven's comments. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/contexts.cc

diff --git a/src/contexts.cc b/src/contexts.cc

index ef480527ff718b41c85f26399d692e3bf521bb42..169d9a12232772a523145e2b3c45db186f02bb1e 100644

--- a/src/contexts.cc

+++ b/src/contexts.cc

@@ -313,8 +313,8 @@ bool Context::IsBootstrappingOrValidParentContext(

if (Isolate::Current()->bootstrapper()->IsActive()) return true;

if (!object->IsContext()) return false;

Context* context = Context::cast(object);

- return context->IsNativeContext() || context->IsModuleContext() ||

- !child->IsModuleContext();

+ return context->IsNativeContext() || context->IsGlobalContext() ||

+ context->IsModuleContext() || !child->IsModuleContext();

}

« no previous file with comments | « src/contexts.h ('k') | src/factory.h » ('j') | no next file with comments »