Issue 10876059: roll gyp 1473:1479

Issue 10876059: roll gyp 1473:1479 (Closed)

Created:
8 years, 4 months ago by Nico

Modified:
8 years, 4 months ago

Reviewers:
scottmg

CC:
chromium-reviews, Alexander Potapenko

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

roll gyp 1473:1479 1474: Emacs mode for gyp: font-lock edition. 1475: Tidy up default toolset for msbuild-based builds. 1476: add -Gstandalone flag 1477: Enable pretty xml generation. 1478: msvs: Ensure trailing slash on IntermediateDir and OutputDir. 1479: mac ninja&make: Pass OTHER_LDFLAGS to libtool for static libraries. Also don't pass -faddress-sanitizer to libtool. BUG=113085 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153250

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : bots #

Patch Set 4 : bots #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -16 lines)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	build/common.gypi	View	1 2 3	2 chunks	+21 lines, -15 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Nico

https://chromiumcodereview.appspot.com/10876059/diff/4001/build/common.gypi File build/common.gypi (right): https://chromiumcodereview.appspot.com/10876059/diff/4001/build/common.gypi#newcode2901 build/common.gypi:2901: '-Wl,-U,_dispatch_after_f', glider: Can this be removed, now that we're ...

8 years, 4 months ago (2012-08-24 01:44:17 UTC) #2

scottmg

pdfsqueeze seems unimpressed with your advances. not sure about libvpx.

8 years, 4 months ago (2012-08-24 02:04:01 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10876059/11001

8 years, 4 months ago (2012-08-24 16:39:09 UTC) #6

Change committed as 153250

Expand Messages | Collapse Messages