Polish the SystemInfoProvider template code and refactor StorageInfoProvider based on it

Polish the SystemInfoProvider template code and refactor StorageInfoProvider based on it.

BUG=136519
TEST=browser_tests --gtest_filter=SystemInfoStorageApiTest.*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153163

[Hongbo Min, 2012-08-23 15:05:05]

Mihai, 
This patch is to refactor system info provider template and rebase system info
provider with it.

Nico, need your lgtm for gyp changes:) 

Thanks.

http://codereview.chromium.org/10876041/diff/1001/chrome/browser/extensions/s...
File chrome/browser/extensions/system_info_provider.h (left):

http://codereview.chromium.org/10876041/diff/1001/chrome/browser/extensions/s...
chrome/browser/extensions/system_info_provider.h:53: 
The Get() is now moved down to the SystemInfoProvider<T> derived class for that
the specific system info provider may have their own additional interfaces
besides QueryInfo. For example, storage info provider also needs an interface to
query the storage unit information with the storage identifier. 

So we need to make sure Get() returns the specific implementation of
SystemInfoProvider<T> class. Otherwise, the Get() has to do downcast operation
from SystemInfoProvider<T> to XXXInfoProvider (e.g. StorageInfoProvider).

[Hongbo Min, 2012-08-24 00:06:13]

mihai, could you pls review it now？

[Mihai Parparita -not on Chrome, 2012-08-24 00:57:29]

LGTM

http://codereview.chromium.org/10876041/diff/1001/chrome/browser/extensions/a...
File chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.h (right):

http://codereview.chromium.org/10876041/diff/1001/chrome/browser/extensions/a...
chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.h:15: virtual
~CpuInfoProvider() {}
Body of this class declaration is indented too much.

http://codereview.chromium.org/10876041/diff/1001/chrome/browser/extensions/a...
File
chrome/browser/extensions/api/system_info_storage/storage_info_provider_linux.cc
(right):

http://codereview.chromium.org/10876041/diff/1001/chrome/browser/extensions/a...
chrome/browser/extensions/api/system_info_storage/storage_info_provider_linux.cc:29:
bool StorageInfoProviderLinux::QueryUnitInfo(StorageUnitInfo* info) {
In the header file this was declared as taking two params (applies to Mac
implementation too).

http://codereview.chromium.org/10876041/diff/1001/chrome/browser/extensions/a...
File
chrome/browser/extensions/api/system_info_storage/system_info_storage_api.cc
(right):

http://codereview.chromium.org/10876041/diff/1001/chrome/browser/extensions/a...
chrome/browser/extensions/api/system_info_storage/system_info_storage_api.cc:31:
SetError("Error occurs when querying storage information.");
"Error occurred" is more correct.

[commit-bot: I haz the power, 2012-08-24 01:26:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hongbo.min@intel.com/10876041/3003

[commit-bot: I haz the power, 2012-08-24 01:26:20]

Presubmit check for 10876041-3003 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
New code should not use wstrings.  If you are calling a cross-platform API that
accepts a wstring, fix the API.
   
chrome/browser/extensions/api/system_info_storage/storage_info_provider_win.cc:60

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 1.6s to calculate.

[Nico, 2012-08-24 01:31:13]

gypi change lgtm

[commit-bot: I haz the power, 2012-08-24 01:32:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hongbo.min@intel.com/10876041/3003

[commit-bot: I haz the power, 2012-08-24 01:32:20]

Presubmit check for 10876041-3003 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
New code should not use wstrings.  If you are calling a cross-platform API that
accepts a wstring, fix the API.
   
chrome/browser/extensions/api/system_info_storage/storage_info_provider_win.cc:60

Presubmit checks took 1.6s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-08-24 02:10:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hongbo.min@intel.com/10876041/8002

[commit-bot: I haz the power, 2012-08-24 04:51:43]

Change committed as 153163