Issue 10876025: Free the command buffer on destruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10876025: Free the command buffer on destruction. (Closed)

Created:
8 years, 4 months ago by greggman

Modified:
8 years, 4 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, apatrick_chromium

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Free the command buffer on destruction. It used to be this happened automagically when the corresponding GPU service code deleted all shared memory for a context but now shared memory is shared by all contexts in a sharegroup so this needs to be freed explicitly. BUG=143799 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152905

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -2 lines)			Patch
M	gpu/command_buffer/client/cmd_buffer_helper.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	gpu/command_buffer/client/cmd_buffer_helper.cc	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation_unittest.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/client/transfer_buffer_unittest.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

greggman

Hey AL, PTAL I'm not 100% sure what happens if there are still commands in ...

8 years, 4 months ago (2012-08-22 22:19:36 UTC) #1

commit-bot: I haz the power

8 years, 4 months ago (2012-08-22 23:07:40 UTC) #3

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gman@chromium.org/10876025/1

Expand Messages | Collapse Messages