Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2443)

Unified Diff: base/observer_list_unittest.cc

Issue 10876012: base: Reverse the parameters passed to EXPECT_EQ in ObserverList test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/observer_list_unittest.cc
diff --git a/base/observer_list_unittest.cc b/base/observer_list_unittest.cc
index 8a8521535c29dfaaece311edea2e1f54347dbb7a..53cc9c03e896345dff78a929d348c05d7e538358 100644
--- a/base/observer_list_unittest.cc
+++ b/base/observer_list_unittest.cc
@@ -201,11 +201,11 @@ TEST(ObserverListTest, BasicTest) {
FOR_EACH_OBSERVER(Foo, observer_list, Observe(10));
- EXPECT_EQ(a.total, 20);
- EXPECT_EQ(b.total, -20);
- EXPECT_EQ(c.total, 0);
- EXPECT_EQ(d.total, -10);
- EXPECT_EQ(e.total, 0);
+ EXPECT_EQ(20, a.total);
+ EXPECT_EQ(-20, b.total);
+ EXPECT_EQ(0, c.total);
+ EXPECT_EQ(-10, d.total);
+ EXPECT_EQ(0, e.total);
}
TEST(ObserverListThreadSafeTest, BasicTest) {
@@ -232,10 +232,10 @@ TEST(ObserverListThreadSafeTest, BasicTest) {
observer_list->Notify(&Foo::Observe, 10);
loop.RunAllPending();
- EXPECT_EQ(a.total, 20);
- EXPECT_EQ(b.total, -20);
- EXPECT_EQ(c.total, 0);
- EXPECT_EQ(d.total, -10);
+ EXPECT_EQ(20, a.total);
+ EXPECT_EQ(-20, b.total);
+ EXPECT_EQ(0, c.total);
+ EXPECT_EQ(-10, d.total);
}
TEST(ObserverListThreadSafeTest, RemoveObserver) {
@@ -255,8 +255,8 @@ TEST(ObserverListThreadSafeTest, RemoveObserver) {
observer_list->Notify(&Foo::Observe, 10);
loop.RunAllPending();
- EXPECT_EQ(a.total, 0);
- EXPECT_EQ(b.total, 0);
+ EXPECT_EQ(0, a.total);
+ EXPECT_EQ(0, b.total);
observer_list->AddObserver(&a);
@@ -266,8 +266,8 @@ TEST(ObserverListThreadSafeTest, RemoveObserver) {
observer_list->Notify(&Foo::Observe, 10);
loop.RunAllPending();
- EXPECT_EQ(a.total, 10);
- EXPECT_EQ(b.total, 0);
+ EXPECT_EQ(10, a.total);
+ EXPECT_EQ(0, b.total);
}
TEST(ObserverListThreadSafeTest, WithoutMessageLoop) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698