Issue 10876010: Treat non-English words as words.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10876010: Treat non-English words as words. (Closed)

Created:
8 years, 4 months ago by Hironori Bono

Modified:
8 years, 3 months ago

Reviewers:
Hajime Morrita

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Treat non-English words as words. This change loosens the check in SpellCheckProvider::HasWordCharacters() so it allows non-Latin words (e.g. Russian, Arabic, etc.) BUG=none TEST=SpellCheckProviderTest.CancelUnnecessaryRequests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153449

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	chrome/renderer/spellchecker/spellcheck_provider.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Hironori Bono

Greetings Morita-san, Sorry for my sudden request. I noticed Chrome cannot check the spelling of ...

8 years, 4 months ago (2012-08-22 09:23:17 UTC) #1

lgtm. 
Thanks for  adding new tests.

Expand Messages | Collapse Messages