Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 10876003: mac: Print an error when doing a branded build and the 10.6 sdk is not around (Closed)

Created:
8 years, 4 months ago by Nico
Modified:
8 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

mac: Print an error when doing a branded build and the 10.6 sdk is not around BUG=144045 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152823

Patch Set 1 #

Patch Set 2 : doh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
M build/common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M build/mac/find_sdk.py View 1 2 chunks +29 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
8 years, 4 months ago (2012-08-22 00:45:07 UTC) #1
Mark Mentovai
I’m not sure if the Xcode 3-running (official) bots will like this. Have you tested ...
8 years, 4 months ago (2012-08-22 13:08:57 UTC) #2
Nico
It was missing a somewhat important bit. With that bit (patch set 2), it seems ...
8 years, 4 months ago (2012-08-22 15:14:18 UTC) #3
Mark Mentovai
LGTM
8 years, 4 months ago (2012-08-22 15:39:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10876003/4001
8 years, 4 months ago (2012-08-22 15:48:13 UTC) #5
commit-bot: I haz the power
Try job failure for 10876003-4001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-22 17:25:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10876003/4001
8 years, 4 months ago (2012-08-22 17:38:42 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-22 19:03:52 UTC) #8
Try job failure for 10876003-4001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Powered by Google App Engine
This is Rietveld 408576698