Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 10875081: Merge 126591 - Crash in RenderTableCell::borderTop() due to custom scrollbars after r124168 (Closed)

Created:
8 years, 3 months ago by Julien - ping for review
Modified:
8 years, 3 months ago
Reviewers:
jchaffraix
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1229/
Visibility:
Public.

Description

Merge 126591 - Crash in RenderTableCell::borderTop() due to custom scrollbars after r124168 https://bugs.webkit.org/show_bug.cgi?id=93903 Reviewed by Tony Chang. Source/WebCore: r124168 changed when we create scrollbars so that it happens (rightly) at style change time. However the RenderScrollbar code assumes that any overflow: scroll RenderScrollbar would be created at layout time as it directly tries to layout to scrollbar parts. The big issues with the move is that the first style change operates on a detached renderer which means that we could crash in some situation. Test: scrollbars/custom-scrollbar-table-cell.html * rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::computeScrollbarWidth): (WebCore::RenderScrollbarPart::computeScrollbarHeight): Fixed the crash by using style information instead of calling the renderer. This is guaranteed to be safe but it also means that custom scrollbars sizing is not right on table cells with collapsing borders. The existing logic was querying layout information at style change so I wouldn't bet on it working properly anyway. LayoutTests: * scrollbars/custom-scrollbar-table-cell-expected.png: Added. * scrollbars/custom-scrollbar-table-cell-expected.txt: Added. * scrollbars/custom-scrollbar-table-cell.html: Added. TBR=jchaffraix@webkit.org Committed: https://trac.webkit.org/changeset/126825

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, --1 lines) Patch
A + LayoutTests/scrollbars/custom-scrollbar-table-cell.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/scrollbars/custom-scrollbar-table-cell-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/scrollbars/custom-scrollbar-table-cell-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/rendering/RenderScrollbarPart.cpp View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Julien - ping for review
8 years, 3 months ago (2012-08-28 00:28:21 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698