Add UMA histogram to determine how often Stage3D could be used.

webkit/plugins/ppapi/ppapi_plugin_instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/ppapi/ppapi_plugin_instance.h"
 
 #include "base/bind.h"
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
 #include "base/memory/linked_ptr.h"
@@ skipping 11 matching lines @@
 #include "ppapi/c/pp_rect.h"
 #include "ppapi/c/ppb_audio_config.h"
 #include "ppapi/c/ppb_core.h"
 #include "ppapi/c/ppb_gamepad.h"
 #include "ppapi/c/ppp_input_event.h"
 #include "ppapi/c/ppp_instance.h"
 #include "ppapi/c/ppp_messaging.h"
 #include "ppapi/c/ppp_mouse_lock.h"
 #include "ppapi/c/private/pp_content_decryptor.h"
 #include "ppapi/c/private/ppp_instance_private.h"
+#include "ppapi/shared_impl/ppapi_preferences.h"
 #include "ppapi/shared_impl/ppb_input_event_shared.h"
 #include "ppapi/shared_impl/ppb_url_util_shared.h"
 #include "ppapi/shared_impl/ppb_view_shared.h"
 #include "ppapi/shared_impl/ppp_instance_combined.h"
 #include "ppapi/shared_impl/resource.h"
 #include "ppapi/shared_impl/scoped_pp_resource.h"
 #include "ppapi/shared_impl/time_conversion.h"
 #include "ppapi/shared_impl/var.h"
 #include "ppapi/thunk/enter.h"
 #include "ppapi/thunk/ppb_buffer_api.h"
@@ skipping 47 matching lines @@
 #endif  // defined(OS_MACOSX)
 
 #if defined(USE_SKIA)
 #include "printing/metafile.h"
 #include "printing/metafile_skia_wrapper.h"
 #include "skia/ext/platform_device.h"
 #endif
 
 #if defined(OS_WIN)
 #include "base/metrics/histogram.h"
+#include "base/win/windows_version.h"
 #include "skia/ext/platform_canvas.h"
 #include "ui/gfx/codec/jpeg_codec.h"
 #include "ui/gfx/gdi_util.h"
 #endif
 
 using base::StringPrintf;
 using ppapi::InputEventData;
 using ppapi::PpapiGlobals;
 using ppapi::PPB_InputEvent_Shared;
 using ppapi::PPB_View_Shared;
@@ skipping 428 matching lines @@
                                 const std::vector<std::string>& arg_names,
                                 const std::vector<std::string>& arg_values,
                                 const GURL& plugin_url,
                                 bool full_frame) {
   container_ = container;
   plugin_url_ = plugin_url;
   full_frame_ = full_frame;
 
   container_->setIsAcceptingTouchEvents(IsAcceptingTouchEvents());
 
+#if defined(OS_WIN)

[brettw, 2012/08/27 22:19:28]

Can you split this into a separate function?

+  if (base::win::GetVersion() <= base::win::VERSION_XP) {
+    ::ppapi::Preferences prefs = delegate_->GetPreferences();
+    bool needsgpu = false;

[vangelis, 2012/08/28 05:12:06]

nit: according to chrome's variable naming convention this should be needs_gpu

+
+    for (unsigned int i = 0; i < arg_names.size(); i++) {

[brettw, 2012/08/27 22:19:28]

Use size_t since that's the type that vector.size() returns.

+      if (arg_names[i] == "wmode") {
+        if (arg_values[i] == "direct" || arg_values[i] == "gpu")
+          needsgpu = true;
+        break;
+      }
+    }
+    UMA_HISTOGRAM_ENUMERATION("Flash.UsesGPU",

[brettw, 2012/08/27 22:19:28]

Can you add a comment here about what this histogram contains? The way you're
using it to communicate capabilities is "nontraditional" :)

+        needsgpu * 2 + prefs.is_webgl_supported, 4);

[vangelis, 2012/08/28 05:12:06]

Is this bool to int conversion pretty standard and supported the same way across
all platforms? 

+  }
+#endif
+
   argn_ = arg_names;
   argv_ = arg_values;
   scoped_array<const char*> argn_array(StringVectorToArgArray(argn_));
   scoped_array<const char*> argv_array(StringVectorToArgArray(argv_));
   return PP_ToBool(instance_interface_->DidCreate(pp_instance(),
                                                   argn_.size(),
                                                   argn_array.get(),
                                                   argv_array.get()));
 }
 
@@ skipping 1876 matching lines @@
   screen_size_for_fullscreen_ = gfx::Size();
   WebElement element = container_->element();
   element.setAttribute(WebString::fromUTF8(kWidth), width_before_fullscreen_);
   element.setAttribute(WebString::fromUTF8(kHeight), height_before_fullscreen_);
   element.setAttribute(WebString::fromUTF8(kBorder), border_before_fullscreen_);
   element.setAttribute(WebString::fromUTF8(kStyle), style_before_fullscreen_);
 }
 
 }  // namespace ppapi
 }  // namespace webkit