Issue 10875070: Makes workspace 2 show an alternate background (system background)

Issue 10875070: Makes workspace 2 show an alternate background (system background) (Closed)

Created:
8 years, 3 months ago by sky

Modified:
8 years, 3 months ago

Reviewers:
mtomasz, Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Makes workspace 2 show an alternate background (system background) beneath the desktop when a window is maximized. This background is visible during the animation and behind the launcher. BUG=137342 TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153509

Patch Set 1 #

Patch Set 2 : Tweaks #

Patch Set 3 : Add delay #

Total comments: 1

Patch Set 4 : More comments #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+190 lines, -22 lines)			Patch
M	ash/ash.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/root_window_controller.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ash/shell_window_ids.h	View	1 2 3	2 chunks	+23 lines, -17 lines	0 comments	Download
M	ash/wm/frame_painter.cc	View	1	3 chunks	+8 lines, -4 lines	0 comments	Download
M	ash/wm/window_animations.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ash/wm/window_animations.cc	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
A	ash/wm/workspace/system_background_controller.h	View	1 2 3	1 chunk	+39 lines, -0 lines	0 comments	Download
A	ash/wm/workspace/system_background_controller.cc	View	1	1 chunk	+79 lines, -0 lines	0 comments	Download
M	ash/wm/workspace/workspace2.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/workspace/workspace_manager2.h	View	1 2	3 chunks	+12 lines, -0 lines	0 comments	Download
M	ash/wm/workspace/workspace_manager2.cc	View	1 2	3 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

lgtm http://codereview.chromium.org/10875070/diff/11/ash/wm/workspace/system_background_controller.h File ash/wm/workspace/system_background_controller.h (right): http://codereview.chromium.org/10875070/diff/11/ash/wm/workspace/system_background_controller.h#newcode18 ash/wm/workspace/system_background_controller.h:18: // SystemBackgroundController shows the system level background. Maybe ...

8 years, 3 months ago (2012-08-27 15:50:46 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10875070/9001

8 years, 3 months ago (2012-08-27 16:03:38 UTC) #3

mtomasz

Why did we do this patch? Why we prefer the black background over user the ...

8 years, 3 months ago (2012-09-20 10:59:17 UTC) #5

sky

8 years, 3 months ago (2012-09-20 15:27:22 UTC) #6

On 2012/09/20 10:59:17, mtomasz wrote:
> Why did we do this patch? Why we prefer the black background over user the
> selected background in maximized mode?
> 
> This doesn't look good to me to be honest.

Its intended to reinforce that the desktop background is attached to the
desktop. When you maximize a window the desktop windows (including the
background) is going into the background so that you no longer see the desktop
background.

If you have concerns you should ping the UX designers.

  -Scott

Expand Messages | Collapse Messages