Require ResultCid specification in every computation, that way we can differentiate between computa…

runtime/vm/flow_graph_optimizer.cc

Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc	(revision 11330)
+++ runtime/vm/flow_graph_optimizer.cc	(working copy)
@@ -923,9 +923,12 @@
     }
     // Propagate class ids.
     intptr_t cid = bind->computation()->ResultCid();
-    changed = bind->SetPropagatedCid(cid);
-    if (changed) {
-      still_changing_ = true;
+    if (cid != kIllegalCid) {

[regis, 2012/08/24 21:30:46]

The equivalent of this test for propagated types is done inside
bind->SetPropagatedType(computation_type). You could keep the symmetry and move
this new test inside bind->SetPropagatedCid(cid).

[srdjan, 2012/08/24 21:39:20]

Done.

+      // The definition may produce result.
+      changed = bind->SetPropagatedCid(cid);
+      if (changed) {
+        still_changing_ = true;
+      }
     }
   }
 }
@@ -970,7 +973,6 @@
   }
 }
 

[regis, 2012/08/24 21:30:46]

Accidental remove?

[srdjan, 2012/08/24 21:39:20]

Yes, reinstated the line.

-
 void FlowGraphTypePropagator::VisitParameter(ParameterInstr* param) {
   // TODO(regis): Once we inline functions, the propagated type of the formal
   // parameter will reflect the compile type of the passed-in argument.