Properly handle Git URLs with trailing slashes.

utils/tests/pub/pub_install_git_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('pub_tests');
 
 #import('dart:io');
 
 #import('test_pub.dart');
 #import('../../../pkg/unittest/unittest.dart');
@@ skipping 60 matching lines @@
         file('foo.dart', 'main() => "foo";')
       ]),
       dir('bar', [
         file('bar.dart', 'main() => "bar";')
       ])
     ]).scheduleValidate();
 
     run();
   });
 
+  test('requires the repository name to match the name in the pubspec', () {
+    ensureGit();
+
+    git('foo.git', [
+      file('foo.dart', 'main() => "foo";')
+    ]).scheduleCreate();
+
+    dir(appPath, [
+      pubspec({
+        "name": "myapp",
+        "dependencies": {
+          "weird-name": {"git": "../foo.git"}
+        }
+      })
+    ]).scheduleCreate();
+
+    // TODO(nweiz): clean up this RegExp when either issue 4706 or 4707 is
+    // fixed.
+    schedulePub(args: ['install'],
+        error: const RegExp(@'^FormatException: The name you specified for '
+            @'your dependency, "weird-name", doesn' @"'" @'t match the name '
+            @'"foo" \(from "\.\./foo\.git"\)\.'));
+
+    run();
+  });
+
   test('checks out and updates a package from Git', () {
     ensureGit();
 
     git('foo.git', [
       file('foo.dart', 'main() => "foo";')
     ]).scheduleCreate();
 
     appDir([{"git": "../foo.git"}]).scheduleCreate();
 
     schedulePub(args: ['install'],
@@ skipping 212 matching lines @@
         output: const RegExp(@"Dependencies installed!$"));
 
     dir(packagesPath, [
       dir('foo', [
         file('foo.dart', 'main() => "foo 1.0.0";')
       ])
     ]).scheduleValidate();
 
     run();
   });
+
+  group("(regression)", () {

[Bob Nystrom, 2012/08/24 21:03:16]

I don't think this group() adds much. Every test is eventually a regression
test. :)

Remove it?

[nweiz, 2012/08/24 21:09:20]

I think there's a useful distinction between tests that specify a core piece of
the behavior of Pub and tests that check for an edge case that was buggy at one
point. This is the sort of test that we'd be unlikely to write when initially
verifying the behavior of the code, but that exists because we've failed to
support this edge case in the past and want to make sure we don't again.

+    test('checks out a package from Git with a trailing slash', () {
+      ensureGit();
+
+      git('foo.git', [
+        file('foo.dart', 'main() => "foo";')
+      ]).scheduleCreate();
+
+      appDir([{"git": "../foo.git/"}]).scheduleCreate();
+
+      schedulePub(args: ['install'],
+          output: const RegExp(@"Dependencies installed!$"));
+
+      dir(cachePath, [
+        dir('git', [
+          dir('cache', [gitPackageCacheDir('foo')]),
+          gitPackageCacheDir('foo')
+        ])
+      ]).scheduleValidate();
+
+      dir(packagesPath, [
+        dir('foo', [
+          file('foo.dart', 'main() => "foo";')
+        ])
+      ]).scheduleValidate();
+
+      run();
+    });
+  });
 }