Roll Breakpad to release 1020

Roll Breakpad to release 1020

This brings in fixes to the Android unit tests.
You can quickly test this with:

  . build/android/envsetup.sh
  GYP_DEFINES="$GYP_DEFINES linux_breakpad=1"
  android_gyp
  make out/Debug/breakpad_unittests
  adb push out/Debug/breakpad_unittests /data/local/tmp/breakpad_unittests
  adb shell /data/local/tmp/breakpad_unittests

BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153653

[digit1, 2012-08-24 16:15:19]

At last.

[Mark Mentovai, 2012-08-27 21:13:10]

https://chromiumcodereview.appspot.com/10875048/diff/1/breakpad/breakpad.gyp
File breakpad/breakpad.gyp (left):

https://chromiumcodereview.appspot.com/10875048/diff/1/breakpad/breakpad.gyp#...
breakpad/breakpad.gyp:525: # Android NDK toolchain doesn't support
-mimplicit-it=always
This was a recent addition, and you’re clobbering it. Any reason, or just
mistake?

https://chromiumcodereview.appspot.com/10875048/diff/1/breakpad/breakpad.gyp
File breakpad/breakpad.gyp (right):

https://chromiumcodereview.appspot.com/10875048/diff/1/breakpad/breakpad.gyp#...
breakpad/breakpad.gyp:529: 'direct_dependent_settings': {
It would be better if the headers that consumers outside of Breakpad rely on
didn’t need Breakpad’s fallback system-replacement headers. Is that possible?

[digit1, 2012-08-27 21:20:29]

https://chromiumcodereview.appspot.com/10875048/diff/1/breakpad/breakpad.gyp
File breakpad/breakpad.gyp (left):

https://chromiumcodereview.appspot.com/10875048/diff/1/breakpad/breakpad.gyp#...
breakpad/breakpad.gyp:224: '__ANDROID__',
For the record, this was removed because this macro is defined by all Android
toolchains by default now.

https://chromiumcodereview.appspot.com/10875048/diff/1/breakpad/breakpad.gyp#...
breakpad/breakpad.gyp:525: # Android NDK toolchain doesn't support
-mimplicit-it=always
I believe the NDK toolchain that is currently used by upstream (GCC 4.6 from NDK
r8b) does support this now, I'll look at the history for this line to be sure
though.

Note that the upstream Chrome for Android build uses toolchain binaries form
third_party/android-tools/ndk/, i.e. the toolchain binaries are
source-controlled to avoid issues when developers don't use exactly the right
version.

Again, let me check and get back to you.

https://chromiumcodereview.appspot.com/10875048/diff/1/breakpad/breakpad.gyp
File breakpad/breakpad.gyp (right):

https://chromiumcodereview.appspot.com/10875048/diff/1/breakpad/breakpad.gyp#...
breakpad/breakpad.gyp:529: 'direct_dependent_settings': {
Unfortunately, not at the moment. I plan to update the NDK headers so all the
things in this directory aren't needed anymore, but until this is publicly
available (and NDK releases take a notoriously long time for non-technical
reasons), this is the best we can do, without introducing plenty of #if
__ANDROID__ in the source code base.

[Mark Mentovai, 2012-08-27 21:30:33]

https://chromiumcodereview.appspot.com/10875048/diff/1/breakpad/breakpad.gyp
File breakpad/breakpad.gyp (right):

https://chromiumcodereview.appspot.com/10875048/diff/1/breakpad/breakpad.gyp#...
breakpad/breakpad.gyp:529: 'direct_dependent_settings': {
digit1 wrote:
> Unfortunately, not at the moment. I plan to update the NDK headers so all the
> things in this directory aren't needed anymore, but until this is publicly
> available (and NDK releases take a notoriously long time for non-technical
> reasons), this is the best we can do, without introducing plenty of #if
> __ANDROID__ in the source code base.

Let’s leave a TODO here to remind us to clean it up whenever that becomes
possible.

[digit1, 2012-08-27 21:50:07]

https://chromiumcodereview.appspot.com/10875048/diff/1/breakpad/breakpad.gyp
File breakpad/breakpad.gyp (left):

https://chromiumcodereview.appspot.com/10875048/diff/1/breakpad/breakpad.gyp#...
breakpad/breakpad.gyp:525: # Android NDK toolchain doesn't support
-mimplicit-it=always
Ok, I checked, the Android toolchain, even old ones, don't need this flag at
all. It looks like this is only required when building for a Linux/ARM platform
that is *not* Android, and thus using a different toolchain  I guess.

This patch doesn't exist in the downstream/internal Chrome for Android tree, but
it seems to have been comitted after the last merge of upstream Chromium into
our tree.

I'm a bit surprised, because "GNU as" has supported the "Unified Assembly
Language" syntax for ARM assembly, which is related to this flag, for a very
long time now, so the original author is either using a very dated toolchain, or
something a bit more custom.

Anyway, I'll keep this in a new patch. Sorry about that, and thanks for spotting
this. The comment above is certainly not correct, so I'll rephrase it.

[digit1, 2012-08-27 22:16:38]

I've upload a 2nd patch set that reverts the __ANDROID__ and
-mimplicit-it=always changes back to the original state. I'd prefer to perform
more checks before touching these. No need to rush for now. I'll try to contact
the author of the -mimplicit patch to see what he's trying to build, in case
similar issues arise in other Linux/ARM related changes.

Verified that Breakpad still built and run properly after this. Thanks again.

[Mark Mentovai, 2012-08-27 22:17:29]

LGTM

[commit-bot: I haz the power, 2012-08-28 08:14:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/digit@chromium.org/10875048/9002

[commit-bot: I haz the power, 2012-08-28 10:43:45]

Change committed as 153653