Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 10875045: Rewrite the cookies pyauto test as browser tests. (Closed)

Created:
8 years, 4 months ago by jam
Modified:
8 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Nirnimesh, jam, joi+watch-content_chromium.org, anantha, darin-cc_chromium.org, dyu1, dennis_jeffrey, markusheintz_
Visibility:
Public.

Description

Rewrite the cookies pyauto test as browser tests. I didn't port testCookiesFile since cookies aren't supposed to work on file urls by default (see crbug.com/535). I removed all the duplicate code for getting cookies in browser tests and moved them to browser_test_utils.h. BUG=143637 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153484

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -354 lines) Patch
M chrome/browser/content_settings/content_settings_browsertest.cc View 1 2 4 chunks +192 lines, -4 lines 0 comments Download
M chrome/browser/fast_shutdown_browsertest.cc View 4 chunks +6 lines, -44 lines 0 comments Download
M chrome/browser/net/cookie_policy_browsertest.cc View 4 chunks +9 lines, -42 lines 0 comments Download
M chrome/test/functional/PYAUTO_TESTS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/functional/cookies.py View 1 chunk +0 lines, -225 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_browsertest.cc View 1 3 chunks +2 lines, -38 lines 0 comments Download
M content/public/test/browser_test_utils.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 4 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jam
8 years, 4 months ago (2012-08-24 02:09:42 UTC) #1
jam
->scottmg since jochen is ooo
8 years, 4 months ago (2012-08-24 22:20:38 UTC) #2
scottmg
probably should tbr jochen for when he gets back, I'm not really sure of all ...
8 years, 4 months ago (2012-08-24 22:59:26 UTC) #3
jam
http://codereview.chromium.org/10875045/diff/9001/chrome/browser/content_settings/content_settings_browsertest.cc File chrome/browser/content_settings/content_settings_browsertest.cc (right): http://codereview.chromium.org/10875045/diff/9001/chrome/browser/content_settings/content_settings_browsertest.cc#newcode166 chrome/browser/content_settings/content_settings_browsertest.cc:166: ASSERT_TRUE(GetCookies(browser()->profile(), url).empty()); On 2012/08/24 22:59:26, scottmg wrote: > the ...
8 years, 4 months ago (2012-08-25 00:23:24 UTC) #4
jochen (gone - plz use gerrit)
lgtm For the record, I want to point out that the pyauto test allowed for ...
8 years, 3 months ago (2012-08-27 15:02:28 UTC) #5
jam
8 years, 3 months ago (2012-08-27 15:04:03 UTC) #6
On Mon, Aug 27, 2012 at 8:02 AM, <jochen@chromium.org> wrote:

> lgtm
>
> For the record, I want to point out that the pyauto test allowed for
> switching
> the site we test against.
>
> This was a work around for poor coverage (the set-cookies.html file only
> exercises one of many possible code paths).
>
> I've filed a bug to add tests for the other paths
>

(per our IM)

cool. adding more test cases should be easy. they really need to go in with
any regressions.

our automated tests shouldn't be hitting live urls though.


>
http://codereview.chromium.**org/10875045/<http://codereview.chromium.org/108...
>

Powered by Google App Engine
This is Rietveld 408576698