Issue 10875028: Wire FileSystemOperation::TouchFile to Drive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10875028: Wire FileSystemOperation::TouchFile to Drive. (Closed)

Created:
8 years, 4 months ago by kinaba

Modified:
8 years, 3 months ago

Reviewers:
satorux1

CC:
chromium-reviews, nkostylev+watch_chromium.org, achuith+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Wire FileSystemOperation::TouchFile to Drive. Full implementation will be made possible once we start using the new Drive API (see the issue tracker for details). For the old WAPI, the operation calls back an 'invalid' error. BUG=144369 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153835

Patch Set 1 #

Patch Set 2 : Rebase on top of GData=>Drive renaming. #

Patch Set 3 : Rebase over FSOI -> FSO renaming. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -3 lines)			Patch
M	chrome/browser/chromeos/gdata/drive_file_system_proxy.h	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/gdata/drive_file_system_proxy.cc	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download
M	webkit/chromeos/fileapi/remote_file_system_operation.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	webkit/chromeos/fileapi/remote_file_system_proxy.h	View	1 2	1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kinaba

On 2012/08/24 03:26:17, kinaba wrote: > Please take a look. Rebased over several renaming works.

8 years, 3 months ago (2012-08-28 06:20:39 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/10875028/10001

8 years, 3 months ago (2012-08-29 01:31:27 UTC) #4

commit-bot: I haz the power

8 years, 3 months ago (2012-08-29 03:01:43 UTC) #5

Try job failure for 10875028-10001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Expand Messages | Collapse Messages