Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: sync/sync.gyp

Issue 10874096: [Sync] Rework Invalidator-related unit tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/notifier/p2p_invalidator_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/sync.gyp
diff --git a/sync/sync.gyp b/sync/sync.gyp
index 369605b2bb6e0988337caaca0a79518f2ccbe080..3d7a3da1344c0c57e4458aacc5b9e0221dc789e0 100644
--- a/sync/sync.gyp
+++ b/sync/sync.gyp
@@ -41,6 +41,7 @@
'sources': [
'base/sync_export.h',
'internal_api/public/base/enum_set.h',
+ 'internal_api/public/base/invalidation_state.cc',
'internal_api/public/base/invalidation_state.h',
'internal_api/public/base/model_type.h',
'internal_api/public/base/model_type_state_map.cc',
@@ -484,6 +485,7 @@
'notifier/fake_invalidator.h',
'notifier/fake_invalidation_handler.cc',
'notifier/fake_invalidation_handler.h',
+ 'notifier/invalidator_test_template.h',
'notifier/object_id_state_map_test_util.cc',
'notifier/object_id_state_map_test_util.h',
],
@@ -573,7 +575,6 @@
'test_support_sync',
],
'direct_dependent_settings': {
- 'variables': { 'enable_wexit_time_destructors': 1, },
'include_dirs': [
'..',
],
@@ -659,7 +660,6 @@
'test_support_sync_notifier',
],
'direct_dependent_settings': {
- 'variables': { 'enable_wexit_time_destructors': 1, },
'include_dirs': [
'..',
],
@@ -671,6 +671,7 @@
'sources': [
'notifier/chrome_invalidation_client_unittest.cc',
'notifier/chrome_system_resources_unittest.cc',
+ 'notifier/fake_invalidator_unittest.cc',
'notifier/invalidation_notifier_unittest.cc',
'notifier/invalidator_registrar_unittest.cc',
'notifier/non_blocking_invalidator_unittest.cc',
@@ -719,7 +720,6 @@
'test_support_syncapi_core',
],
'direct_dependent_settings': {
- 'variables': { 'enable_wexit_time_destructors': 1, },
'include_dirs': [
'..',
],
@@ -765,7 +765,6 @@
'test_support_syncapi_service',
],
'direct_dependent_settings': {
- 'variables': { 'enable_wexit_time_destructors': 1, },
'include_dirs': [
'..',
],
@@ -780,6 +779,8 @@
{
'target_name': 'sync_unit_tests',
'type': '<(gtest_target_type)',
+ # Typed-parametrized tests generate exit-time destructors.
+ 'variables': { 'enable_wexit_time_destructors': 0, },
'dependencies': [
'../base/base.gyp:run_all_unittests',
'sync_tests',
« no previous file with comments | « sync/notifier/p2p_invalidator_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698