Issue 10874095: Add target for webkit_compositor_unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10874095: Add target for webkit_compositor_unittests (Closed)

Created:
8 years, 3 months ago by jamesr

Modified:
8 years, 3 months ago

Reviewers:
nduca, enne (OOO)

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add target for webkit_compositor_unittests We need a target for unit tests that test the compositor WebKit APIs but have knowledge of the implementation (CC guts). This sets up the test target and puts a few tests in place. Like cc_unittests, this target doesn't work in the component build and won't until we break link-time dependencies on non-exported WebCore symbols. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153798

Patch Set 1 #

Patch Set 2 : move webkit_compositor_unittests to separate gyp file #

Patch Set 3 : compositor_tests.gyp might come in handy #

Patch Set 4 : fix up gyp #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+552 lines, -1 line)			Patch
M	build/all.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	webkit/compositor/WebFloatAnimationCurveTest.cpp	View		1 chunk	+216 lines, -0 lines	0 comments	Download
A	webkit/compositor/WebTransformAnimationCurveTest.cpp	View		1 chunk	+277 lines, -0 lines	0 comments	Download
M	webkit/compositor/compositor.gyp	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
A	webkit/compositor/compositor_tests.gyp	View	1 2 3	1 chunk	+50 lines, -0 lines	0 comments	Download
M	webkit/compositor/copyfiles.py	View		2 chunks	+7 lines, -1 line	0 comments	Download
A +	webkit/compositor/test/run_all_unittests.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jamesr

8 years, 3 months ago (2012-08-28 07:52:06 UTC) #4

The gyp generator (at least on mac) is unhappy about the things the test put in
the .gyp since it creates a cycle through webkit_support, so I've split the
tests out to a separate gyp like with cc_unittests. Take that, trybots!

Expand Messages | Collapse Messages