Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: lib/mirrors.cc

Issue 10874072: Use the return value of vm native methods to set the return value, (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/math.cc ('k') | lib/object.cc » ('j') | vm/bootstrap_natives.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/mirrors.cc
===================================================================
--- lib/mirrors.cc (revision 11528)
+++ lib/mirrors.cc (working copy)
@@ -2,11 +2,10 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-#include "vm/bootstrap_natives.h"
-
-#include "platform/json.h"
#include "include/dart_api.h"
#include "include/dart_debugger_api.h"
+#include "platform/json.h"
+#include "vm/bootstrap_natives.h"
#include "vm/dart_entry.h"
#include "vm/exceptions.h"
#include "vm/message.h"
@@ -28,8 +27,7 @@
Integer& id = Integer::Handle();
id ^= id_obj.raw();
Dart_Port port_id = static_cast<Dart_Port>(id.AsInt64Value());
- const Bool& is_local = Bool::Handle(Bool::Get(PortMap::IsLocalPort(port_id)));
- arguments->SetReturn(is_local);
+ return Bool::Get(PortMap::IsLocalPort(port_id));
}
« no previous file with comments | « lib/math.cc ('k') | lib/object.cc » ('j') | vm/bootstrap_natives.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698