Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: runtime/vm/object.cc

Issue 10874071: Eliminate interface bool (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/object_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc (revision 11414)
+++ runtime/vm/object.cc (working copy)
@@ -560,7 +560,7 @@
cls = Class::New<Bool>();
object_store->set_bool_class(cls);
name = Symbols::Bool();
- RegisterClass(cls, name, core_impl_lib);
+ RegisterClass(cls, name, core_lib);
pending_classes.Add(cls, Heap::kOld);
cls = object_store->array_class(); // Was allocated above.
@@ -788,11 +788,6 @@
type = Type::NewNonParameterizedType(cls);
object_store->set_string_interface(type);
- cls = CreateAndRegisterInterface("bool", script, core_lib);
- pending_classes.Add(cls, Heap::kOld);
- type = Type::NewNonParameterizedType(cls);
- object_store->set_bool_interface(type);
-
cls = CreateAndRegisterInterface("List", script, core_lib);
pending_classes.Add(cls, Heap::kOld);
type = Type::NewNonParameterizedType(cls);
@@ -803,6 +798,10 @@
type = Type::NewNonParameterizedType(cls);
object_store->set_byte_array_interface(type);
+ cls = object_store->bool_class();
+ type = Type::NewNonParameterizedType(cls);
+ object_store->set_bool_type(type);
+
cls = object_store->smi_class();
type = Type::NewNonParameterizedType(cls);
object_store->set_smi_type(type);
@@ -1166,8 +1165,6 @@
case kExternalTwoByteStringCid:
case kExternalFourByteStringCid:
return Symbols::New("String");
- case kBoolCid:
- return Symbols::New("bool");
case kArrayCid:
case kImmutableArrayCid:
case kGrowableObjectArrayCid:
@@ -2556,9 +2553,9 @@
}
-bool AbstractType::IsBoolInterface() const {
+bool AbstractType::IsBoolType() const {
return HasResolvedTypeClass() &&
- (type_class() == Type::Handle(Type::BoolInterface()).type_class());
+ (type_class() == Type::Handle(Type::BoolType()).type_class());
}
@@ -2689,8 +2686,8 @@
}
-RawType* Type::BoolInterface() {
- return Isolate::Current()->object_store()->bool_interface();
+RawType* Type::BoolType() {
+ return Isolate::Current()->object_store()->bool_type();
}
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/object_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698