Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 10874067: chromeos: Move src/chrome/browser/chromeos/disks to src/chromeos (Closed)

Created:
8 years, 3 months ago by hashimoto
Modified:
8 years, 3 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, tbarzic+watch_chromium.org, achuith+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Move src/chrome/browser/chromeos/disks to src/chromeos GetSizeStatsOnFileThread is moved from disk_mount_manager.cc to file_browser_private_api.cc BUG=None TEST=build TBR=estade@chromium.org, kaznacheev@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1387 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/burn_library.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/disks/disk_mount_manager.h View 1 chunk +0 lines, -270 lines 0 comments Download
D chrome/browser/chromeos/disks/disk_mount_manager.cc View 1 chunk +0 lines, -706 lines 0 comments Download
D chrome/browser/chromeos/disks/mock_disk_mount_manager.h View 1 chunk +0 lines, -103 lines 0 comments Download
D chrome/browser/chromeos/disks/mock_disk_mount_manager.cc View 1 chunk +0 lines, -235 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_event_router.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 5 chunks +23 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/imageburner/burn_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_gallery/media_device_notifications_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_gallery/media_device_notifications_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/volume_manager.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M chromeos/chromeos.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
A + chromeos/disks/disk_mount_manager.h View 4 chunks +5 lines, -8 lines 0 comments Download
A + chromeos/disks/disk_mount_manager.cc View 8 chunks +1 line, -33 lines 0 comments Download
A + chromeos/disks/mock_disk_mount_manager.h View 3 chunks +4 lines, -6 lines 0 comments Download
A + chromeos/disks/mock_disk_mount_manager.cc View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hashimoto
Oshima: Could you review this whole move? Toni: Could you review the changes for file_browser_private_api.cc?
8 years, 3 months ago (2012-08-24 21:26:13 UTC) #1
tbarzic
On 2012/08/24 21:26:13, hashimoto wrote: > Oshima: Could you review this whole move? > Toni: ...
8 years, 3 months ago (2012-08-24 21:38:04 UTC) #2
oshima
lgtm
8 years, 3 months ago (2012-08-25 00:38:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10874067/1
8 years, 3 months ago (2012-08-25 00:41:27 UTC) #4
commit-bot: I haz the power
Presubmit check for 10874067-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-08-25 00:41:39 UTC) #5
hashimoto
TBR-ing estade@ for media_gallery and kaznacheev@ for file_manager. On 2012/08/25 00:41:39, I haz the power ...
8 years, 3 months ago (2012-08-25 00:45:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10874067/1
8 years, 3 months ago (2012-08-25 00:45:55 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-08-26 12:02:40 UTC) #8
Change committed as 153402

Powered by Google App Engine
This is Rietveld 408576698