Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 10874066: Switch RenderTextMac to use point font sizes instead of pixel font sizes. (Closed)

Created:
8 years, 4 months ago by Alexei Svitkine (slow)
Modified:
8 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Switch RenderTextMac to use point font sizes instead of pixel font sizes. The previous implementation tried to use pixel sizes for consistency with implementations of RenderText on other platforms. However, it turns out that Skia itself uses point font sizes on Mac as does gfx::Font, so it makes more sense to use point sizes throughout. BUG=125664, 137033 TEST=Patch in http://codereview.chromium.org/10879069/ and bring up a print preview on www.google.com. Letter spacing for the header and footer text should be the same as what's produced by current Canary. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153599

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -67 lines) Patch
M ui/gfx/render_text_mac.cc View 3 chunks +4 lines, -67 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Alexei Svitkine (slow)
8 years, 4 months ago (2012-08-24 18:43:11 UTC) #1
Alexei Svitkine (slow)
Ping!
8 years, 3 months ago (2012-08-27 13:57:03 UTC) #2
Nico
LGTM On 2012/08/27 13:57:03, Alexei Svitkine wrote: > Ping! You can check who/reviewerlogin/calendar to check ...
8 years, 3 months ago (2012-08-27 18:57:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10874066/1
8 years, 3 months ago (2012-08-27 19:00:36 UTC) #4
Alexei Svitkine (slow)
On 2012/08/27 18:57:38, Nico wrote: > I was out Friday. No worries. (The ping was ...
8 years, 3 months ago (2012-08-27 19:01:29 UTC) #5
commit-bot: I haz the power
Try job failure for 10874066-1 (retry) on win_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 3 months ago (2012-08-27 22:31:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10874066/1
8 years, 3 months ago (2012-08-27 22:44:17 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-08-28 01:03:49 UTC) #8
Change committed as 153599

Powered by Google App Engine
This is Rietveld 408576698