Issue 10874064: Fixes crash introduced @ 153047 (you can hit crash by maximizing a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10874064: Fixes crash introduced @ 153047 (you can hit crash by maximizing a (Closed)

Created:
8 years, 4 months ago by sky

Modified:
8 years, 4 months ago

Reviewers:
Ian Vollick

CC:
chromium-reviews, piman+watch_chromium.org, jonathan.backer, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixes crash introduced @ 153047 (you can hit crash by maximizing a window). The cross fade code deletes the layer when the animation finishes. The newly added code was accessing members after the animation finished and the animator was deleted, resulting in the crash. Since I'm sure this will come up more in the future I've restructured the code to allow for deletion when calling out like this. The cross fade test exercises this code path now, but I'll see about a more focused tests shortly. BUG=129033 TEST=covered by tests. R=vollick@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153291

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -26 lines)			Patch
M	ash/wm/window_animations.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ash/wm/window_animations.cc	View	3 chunks	+1 line, -12 lines	0 comments	Download
M	ash/wm/window_animations_unittest.cc	View	4 chunks	+18 lines, -6 lines	0 comments	Download
M	ui/compositor/layer_animation_observer.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/compositor/layer_animation_observer.cc	View	2 chunks	+11 lines, -2 lines	0 comments	Download
M	ui/compositor/layer_animator.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/compositor/layer_animator.cc	View	3 chunks	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ian Vollick

On 2012/08/24 17:47:14, sky wrote: LGTM. Thank you for doing this.

8 years, 4 months ago (2012-08-24 18:41:17 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10874064/1

8 years, 4 months ago (2012-08-24 19:01:28 UTC) #3

Change committed as 153291

Expand Messages | Collapse Messages