Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 10874058: Remove invalid Chrome To Mobile DCHECK, infer notifications are enabled on receipt. (Closed)

Created:
8 years, 4 months ago by msw
Modified:
8 years, 4 months ago
Reviewers:
akalin, sky
CC:
chromium-reviews, nyquist, tim (not reviewing), dcheng
Visibility:
Public.

Description

Remove invalid Chrome To Mobile DCHECK, infer notifications are enabled on receipt. DCHECK from http://crrev.com/152801 may fail in known acceptable cases: See ctor: // TODO(msw|akalin): Initialize |sync_invalidation_enabled_| properly. OnIncomingNotification may be called before/after OnNotifications[En|Dis]abled. This is related to (and partially blocked by) Issues 142475 and 137086. BUG=144589, 142475, 137086 TEST=No crash, no send failures due to notifications-enabled false positive. TBR=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153309

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/chrome_to_mobile_service.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
msw
Hey Fred, please take a look; thanks!
8 years, 4 months ago (2012-08-24 09:35:25 UTC) #1
akalin
LGTM 142475 is probably a better bug to cite than 137086. Probably not a good ...
8 years, 4 months ago (2012-08-24 16:57:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10874058/1
8 years, 4 months ago (2012-08-24 18:20:55 UTC) #3
commit-bot: I haz the power
Presubmit check for 10874058-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-24 18:21:00 UTC) #4
msw
TBR'ing Scott for OWNERS.
8 years, 4 months ago (2012-08-24 18:29:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10874058/1
8 years, 4 months ago (2012-08-24 18:29:43 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-24 22:07:28 UTC) #7
Change committed as 153309

Powered by Google App Engine
This is Rietveld 408576698