net/http/http_response_headers.cc - Issue 10874054: Add WARN_UNUSED_RESULT to scoped_refptr::release.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_response_headers.cc

Issue 10874054: Add WARN_UNUSED_RESULT to scoped_refptr::release. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Don't assign NULL to pointer to scoped_refptr. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_response_headers.cc

diff --git a/net/http/http_response_headers.cc b/net/http/http_response_headers.cc

index 0d2279b63e01dee96a0210d94d10e60d2447d868..7e6b076742c652c97d813f42b252434ab53a346c 100644

--- a/net/http/http_response_headers.cc

+++ b/net/http/http_response_headers.cc

@@ -1293,7 +1293,7 @@ Value* HttpResponseHeaders::NetLogCallback(

bool HttpResponseHeaders::FromNetLogParam(

const base::Value* event_param,

scoped_refptr<HttpResponseHeaders>* http_response_headers) {

- http_response_headers->release();

+ *http_response_headers = NULL;

const base::DictionaryValue* dict;

const base::ListValue* header_list;

« no previous file with comments | « gpu/command_buffer/service/context_group.cc ('k') | no next file » | no next file with comments »