Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 10874052: Make ModuleSystem::DumpException() handle empty handles. (Closed)

Created:
8 years, 4 months ago by koz (OOO until 15th September)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Make ModuleSystem::DumpException() handle empty handles. BUG=144436 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153283

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M chrome/renderer/module_system.cc View 1 chunk +17 lines, -6 lines 1 comment Download

Messages

Total messages: 10 (0 generated)
koz (OOO until 15th September)
8 years, 4 months ago (2012-08-24 00:49:47 UTC) #1
Aaron Boodman
lgtm, thanks for quick fix
8 years, 4 months ago (2012-08-24 13:37:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10874052/1
8 years, 4 months ago (2012-08-24 18:03:46 UTC) #3
commit-bot: I haz the power
Presubmit check for 10874052-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-24 18:03:55 UTC) #4
Aaron Boodman
OWNER review please?
8 years, 4 months ago (2012-08-24 18:24:54 UTC) #5
Lei Zhang
lgtm with nit below https://chromiumcodereview.appspot.com/10874052/diff/1/chrome/renderer/module_system.cc File chrome/renderer/module_system.cc (right): https://chromiumcodereview.appspot.com/10874052/diff/1/chrome/renderer/module_system.cc#newcode73 chrome/renderer/module_system.cc:73: message->GetScriptResourceName()->ToString()); nit: weird spacing. How ...
8 years, 4 months ago (2012-08-24 18:31:47 UTC) #6
Aaron Boodman
Agree, but the author of this patch is away, and we need to get it ...
8 years, 4 months ago (2012-08-24 18:47:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10874052/1
8 years, 4 months ago (2012-08-24 18:47:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10874052/1
8 years, 4 months ago (2012-08-24 18:48:27 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-24 21:05:48 UTC) #10
Change committed as 153283

Powered by Google App Engine
This is Rietveld 408576698