Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: utils/pub/git_source.dart

Issue 10874051: Support self-referential package: imports with Pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: utils/pub/git_source.dart
diff --git a/utils/pub/git_source.dart b/utils/pub/git_source.dart
index 4efb21bff2889670e2e0e2afbd6657f6ad560f1b..7f59d8941e9a15b578e2cd6bc6d9fd3ba9cda2ba 100644
--- a/utils/pub/git_source.dart
+++ b/utils/pub/git_source.dart
@@ -122,8 +122,8 @@ class GitSource extends Source {
return exists(path).chain((exists) {
if (!exists) return _clone(_getUrl(id), path);
- return runProcess("git", ["pull", "--force"], workingDir: path,
- pipeStdout: true, pipeStderr: true).transform((result) {
+ return runProcess("git", ["pull", "--force"], workingDir: path)
+ .transform((result) {
if (!result.success) throw 'Git failed.';
return null;
});
@@ -135,7 +135,7 @@ class GitSource extends Source {
*/
Future<String> _revisionAt(PackageId id) {
return runProcess("git", ["rev-parse", _getEffectiveRef(id)],
- workingDir: _repoCachePath(id), pipeStderr: true).transform((result) {
+ workingDir: _repoCachePath(id)).transform((result) {
if (!result.success) throw 'Git failed.';
return result.stdout[0];
});
@@ -155,8 +155,7 @@ class GitSource extends Source {
* Clones the repo at the URI [from] to the path [to] on the local filesystem.
*/
Future _clone(String from, String to) {
- return runProcess("git", ["clone", from, to], pipeStdout: true,
- pipeStderr: true).transform((result) {
+ return runProcess("git", ["clone", from, to]).transform((result) {
if (!result.success) throw 'Git failed.';
return null;
});
@@ -166,8 +165,8 @@ class GitSource extends Source {
* Checks out the reference [ref] in [repoPath].
*/
Future _checkOut(String repoPath, String ref) {
- return runProcess("git", ["checkout", ref], pipeStdout: true,
- pipeStderr: true, workingDir: repoPath).transform((result) {
+ return runProcess("git", ["checkout", ref], workingDir: repoPath)
+ .transform((result) {
if (!result.success) throw 'Git failed.';
return null;
});

Powered by Google App Engine
This is Rietveld 408576698