Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 10874047: MIPS: Allow uint32 value on optimized frames if they are consumed by safe operations. (Closed)

Created:
8 years, 4 months ago by palfia
Modified:
8 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Allow uint32 value on optimized frames if they are consumed by safe operations. Port r12367 (27f16c18) Original commit message: Safe operations are those that either do not observe unsignedness or have special support for uint32 values: - all binary bitwise operations: they perform ToInt32 on inputs; - >> and << shifts: they perform ToInt32 on left hand side and ToUint32 on right hand side; - >>> shift: it performs ToUint32 on both inputs; - stores to integer external arrays (not pixel, float or double ones): these stores are "bitwise"; - HChange: special support added for conversions of uint32 values to double and tagged values; - HSimulate: special support added for deoptimization with uint32 values in registers and stack slots; - HPhi: phis that have only safe uses and only uint32 operands are uint32 themselves. BUG=v8:2097 TEST=test/mjsunit/compiler/uint32.js

Patch Set 1 #

Patch Set 2 : Rebased on r12414 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -31 lines) Patch
M src/mips/lithium-codegen-mips.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 8 chunks +70 lines, -18 lines 0 comments Download
M src/mips/lithium-mips.h View 1 4 chunks +22 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 3 chunks +24 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
8 years, 4 months ago (2012-08-23 23:07:11 UTC) #1
palfia
Rebased on r12414
8 years, 3 months ago (2012-08-30 22:31:34 UTC) #2
Sven Panne
8 years, 3 months ago (2012-09-03 06:18:54 UTC) #3
LGTM (rubberstamp), landing...

Powered by Google App Engine
This is Rietveld 408576698