Activated send-to-mobile and bookmark in action box for Windows.

Activated send-to-mobile and bookmark in action box for Windows.

BUG=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153532

[beaudoin, 2012-08-23 21:43:06]

I've hooked up the two actions currently in the action box menu so they trigger
the corresponding actions in the model.

[msw, 2012-08-23 22:04:40]

The off-by-one conversion seems really hacky, and I don't see where that's done
on Mac. Could we perhaps extend/mimic |id_to_extension_id_map_| to accommodate
these items with their IDC_* enum values or similar?

http://codereview.chromium.org/10874040/diff/1/chrome/browser/ui/views/action...
File chrome/browser/ui/views/action_box_menu.cc (right):

http://codereview.chromium.org/10874040/diff/1/chrome/browser/ui/views/action...
chrome/browser/ui/views/action_box_menu.cc:25: // Converts from the index of a
menu item to the id of this item. Indices are
nit: add a blank line above.

[beaudoin, 2012-08-24 19:34:38]

I've switched it to use the IDCs but had to make some methods publicly visible
in the model. I think it makes sense as these methods are part of the public
interface of ui::SimpleMenuModel::Delegate.

BTW: The Mac side stores the index (and not the IDC) in the menu item's tag (the
equivalent of views item_id). The difference is that Mac allows 0 as a tag
whereas views prohibits it.

http://codereview.chromium.org/10874040/diff/1/chrome/browser/ui/views/action...
File chrome/browser/ui/views/action_box_menu.cc (right):

http://codereview.chromium.org/10874040/diff/1/chrome/browser/ui/views/action...
chrome/browser/ui/views/action_box_menu.cc:25: // Converts from the index of a
menu item to the id of this item. Indices are
On 2012/08/23 22:04:40, msw wrote:
> nit: add a blank line above.

Done.

[msw, 2012-08-24 19:50:20]

Awesome; LGTM, thanks!

[beaudoin, 2012-08-27 16:03:28]

@sky ping

[sky, 2012-08-27 16:39:31]

LGTM

[commit-bot: I haz the power, 2012-08-27 18:15:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/beaudoin@chromium.org/10874040/7002

[commit-bot: I haz the power, 2012-08-27 20:33:41]

Change committed as 153532