Rename GDataFileSystem* to DriveFileSystem*

Rename GDataFileSystem* to DriveFileSystem*

In this CL,
* gdata_file_system_interface.h has been renamed to drive_file_system_interface.{h,cc}
* gdata_file_system.{h,cc} have been renamed to drive_file_system.{h,cc}
* same for gdata_file_system_unittest.cc, gdata_file_system_proxy.{h,cc}, mock_gdata_file_system.{h,cc}
* class GDataFileSystemInterface has been renamed to DriveFileSystemInterface.
* class DriveFileSystem has been renamed to DriveFileSystem.

This change applies on top of
https://chromiumcodereview.appspot.com/10878023/

BUG=137151
TEST=pass all existing tests.
TBR=satorux@chromium.org, ben@chromium.org, estade@chromium.org, rginda@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153044

[kochi, 2012-08-23 08:49:30]

Hi Satoru,

Could you review this?
Thanks!

[kochi, 2012-08-23 09:56:20]

Kazuhiro, could you take a look at this CL for Satoru's absence?
Thanks,

On 2012/08/23 08:49:30, Takayoshi Kochi wrote:
> Hi Satoru,
> 
> Could you review this?
> Thanks!

[kinaba, 2012-08-23 10:28:45]

lgtm with nits.

http://codereview.chromium.org/10874028/diff/5054/chrome/browser/chromeos/ext...
File chrome/browser/chromeos/extensions/file_browser_event_router.cc (right):

http://codereview.chromium.org/10874028/diff/5054/chrome/browser/chromeos/ext...
chrome/browser/chromeos/extensions/file_browser_event_router.cc:39: using
gdata::DriveFileSystemInterface;
Can we remove this using declaration? It looks all the usage of the class name
is qualified with gdata::.

http://codereview.chromium.org/10874028/diff/5054/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_sync_client.h (right):

http://codereview.chromium.org/10874028/diff/5054/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_sync_client.h:79: //
DriveFileSystemInterface overrides.
DriveFileSystemInterface::Observer overrides.

http://codereview.chromium.org/10874028/diff/5054/chrome/browser/download/sav...
File chrome/browser/download/save_package_file_picker_chromeos.h (right):

http://codereview.chromium.org/10874028/diff/5054/chrome/browser/download/sav...
chrome/browser/download/save_package_file_picker_chromeos.h:14: class
DriveFileSystem;
Not used in this header.

http://codereview.chromium.org/10874028/diff/5054/webkit/chromeos/fileapi/rem...
File webkit/chromeos/fileapi/remote_file_stream_writer.h (right):

http://codereview.chromium.org/10874028/diff/5054/webkit/chromeos/fileapi/rem...
webkit/chromeos/fileapi/remote_file_stream_writer.h:25: // FileStreamWriter
interface for writing to a file on Drive file system.
Ahh, I'm the original writer of this comment ;(, but

// FileStreamWriter interface for writing to a file on a remote file system.

would be a more accurate comment, even though it is only instantiated with
GData/Drive fs for now. Could you fix this?

[kochi, 2012-08-23 10:50:32]

Thanks for the review!

All comments are addressed.

After the dependent CL is done, I'll submit via CQ.

https://chromiumcodereview.appspot.com/10874028/diff/5054/chrome/browser/chro...
File chrome/browser/chromeos/extensions/file_browser_event_router.cc (right):

https://chromiumcodereview.appspot.com/10874028/diff/5054/chrome/browser/chro...
chrome/browser/chromeos/extensions/file_browser_event_router.cc:39: using
gdata::DriveFileSystemInterface;
On 2012/08/23 10:28:46, kinaba wrote:
> Can we remove this using declaration? It looks all the usage of the class name
> is qualified with gdata::.

Done.

https://chromiumcodereview.appspot.com/10874028/diff/5054/chrome/browser/chro...
File chrome/browser/chromeos/gdata/gdata_sync_client.h (right):

https://chromiumcodereview.appspot.com/10874028/diff/5054/chrome/browser/chro...
chrome/browser/chromeos/gdata/gdata_sync_client.h:79: //
DriveFileSystemInterface overrides.
On 2012/08/23 10:28:46, kinaba wrote:
> DriveFileSystemInterface::Observer overrides.

Done.

https://chromiumcodereview.appspot.com/10874028/diff/5054/chrome/browser/down...
File chrome/browser/download/save_package_file_picker_chromeos.h (right):

https://chromiumcodereview.appspot.com/10874028/diff/5054/chrome/browser/down...
chrome/browser/download/save_package_file_picker_chromeos.h:14: class
DriveFileSystem;
On 2012/08/23 10:28:46, kinaba wrote:
> Not used in this header.

Done.

https://chromiumcodereview.appspot.com/10874028/diff/5054/webkit/chromeos/fil...
File webkit/chromeos/fileapi/remote_file_stream_writer.h (right):

https://chromiumcodereview.appspot.com/10874028/diff/5054/webkit/chromeos/fil...
webkit/chromeos/fileapi/remote_file_stream_writer.h:25: // FileStreamWriter
interface for writing to a file on Drive file system.
On 2012/08/23 10:28:46, kinaba wrote:
> Ahh, I'm the original writer of this comment ;(, but
> 
> // FileStreamWriter interface for writing to a file on a remote file system.
> 
> would be a more accurate comment, even though it is only instantiated with
> GData/Drive fs for now. Could you fix this?

Done.

[kochi, 2012-08-23 10:55:19]

Added TBR= line,

ben@ for .gypi changes,
satorux@ for c/b/ui/webui/chromeos/* and webkit/chromeos/*,
estade@ for c/b/ui/webui/*,
rginda@ for c/b/resources/file_manager

I'd appreciate if you can take a look.

[commit-bot: I haz the power, 2012-08-23 16:36:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kochi@chromium.org/10874028/2007

[commit-bot: I haz the power, 2012-08-23 19:06:57]

Change committed as 153044

[Ben Goodger (Google), 2012-08-23 19:38:22]

lgtm