Issue 10874025: Use dummynet-based network simulation for Mac tests.

Issue 10874025: Use dummynet-based network simulation for Mac tests. (Closed)

Created:
8 years, 4 months ago by slamm

Modified:
8 years, 3 months ago

Reviewers:
Nirnimesh

CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh, cmp, sullivan

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use dummynet-based network simulation for Mac tests. NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153791

Patch Set 2 : Add comment about network simulation options. #

Patch Set 3 : Drop DEPS change (previously applied) #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -8 lines)			Patch
	M	chrome/test/functional/perf.py	View	1	2 chunks	+12 lines, -4 lines	0 comments	Download
	M	chrome/test/functional/webpagereplay.py	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

slamm

Use dummynet to simulate FIOS latency/bandwith. Macs have dummynet by default. (This will require one ...

8 years, 4 months ago (2012-08-22 23:18:46 UTC) #1

Nirnimesh

LGTM https://chromiumcodereview.appspot.com/10874025/diff/1/chrome/test/functional/perf.py File chrome/test/functional/perf.py (right): https://chromiumcodereview.appspot.com/10874025/diff/1/chrome/test/functional/perf.py#newcode2314 chrome/test/functional/perf.py:2314: if self.IsMac(): please add a comment here

8 years, 4 months ago (2012-08-22 23:40:49 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/slamm@chromium.org/10874025/4001

8 years, 3 months ago (2012-08-28 21:07:39 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/slamm@chromium.org/10874025/4001

8 years, 3 months ago (2012-08-28 21:39:57 UTC) #4

commit-bot: I haz the power

Failed to apply patch for DEPS: While running patch -p1 --forward --force; patching file DEPS ...

8 years, 3 months ago (2012-08-28 22:04:48 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/slamm@chromium.org/10874025/16002

8 years, 3 months ago (2012-08-28 23:31:27 UTC) #6

Change committed as 153791

Expand Messages | Collapse Messages